PR#42: Opt-in for python3 - fedora-project-config

fedora-project-config

#42 Opt-in for python3

Merged 5 years ago by zuul. Opened 5 years ago by churchyard.

churchyard/fedora-project-config python3 into master

Miro Hrončok • 5 years ago

9bfcfc9

resources/fedora.yaml

file modified

		`@@ -13,6 +13,9 @@`
		`- fedora-zuul-jobs`
		`- test-python-package-zuul-workflow:`
		`zuul/include: []`
		`+ - rpms/python3:`
		`+ connection: src.fedoraproject.org`
		`+ zuul/include: []`
		`- rpms/python-gear:`
		`connection: src.fedoraproject.org`
		`zuul/include: []`

churchyard commented 5 years ago

I have followed https://fedoraproject.org/wiki/Zuul-based-ci#Configure_the_repository_for_Zuul except I haven't added the zuul account as a committer. I suppose that should not be needed to test things, if we don't want to use the "gateit" tag workflow yet.

Let me know if that is actually needed even to test PRs.

zuul commented 5 years ago

Build failed.

config-check : FAILURE in 38s

churchyard commented 5 years ago

Traceback (most recent call last):
  File "/usr/bin/managesf-resources", line 10, in <module>
    sys.exit(cli())
  File "/usr/lib/python3.6/site-packages/managesf/cmds/resources.py", line 242, in cli
    args.zuul_prev_commit, args.zuul_commit)
  File "/usr/lib/python3.6/site-packages/managesf/cmds/resources.py", line 76, in read_repo_to_validate
    print(head_commit_msg)
UnicodeEncodeError: 'ascii' codec can't encode character '\u010d' in position 65: ordinal not in range(128)

That's č in my name (git commit author) if that helps.

Edited 5 years ago by churchyard

tdecacqu commented 5 years ago

recheck

oops, I added an encode errors 'ignore' quick fix

tdecacqu commented 5 years ago

recheck

zuul commented 5 years ago

Build failed.

config-check : FAILURE in 55s

tdecacqu commented 5 years ago

recheck

zuul commented 5 years ago

Build succeeded.

config-check : SUCCESS in 41s

churchyard commented 5 years ago

\o/

tdecacqu commented 5 years ago

For the record, here is the quickfix we deployed: https://softwarefactory-project.io/r/17378

tdecacqu commented 5 years ago

@churchyard would you like to get this change merged and applies now?

churchyard commented 5 years ago

For the record, here is the quickfix we deployed: https://softwarefactory-project.io/r/17378

Would running the proces with an UTF-8 locale set be a proper fix? prinitng unicode strings should work if the locale supports it, such as C.UTF-8 (or en_US.UTF-8 on older systems such as EL7).

churchyard commented 5 years ago

And yes, I want this PR merged, so I can test the zuul CI on existing PRs: https://src.fedoraproject.org/rpms/python3/pull-requests