PR#32: Do no include Zuul conf from package repo - fedora-project-config

fedora-project-config

#32 Do no include Zuul conf from package repo

Merged 4 years ago by zuul. Opened 4 years ago by fbo.

fbo/fedora-project-config zuul-include into master

Do no include Zuul conf from package repo

Fabien Boucher • 4 years ago

55baddf

resources/fedora.yaml

file modified

+5 -1

		`@@ -11,10 +11,14 @@`
		`- fedora-zuul-jobs-config:`
		`zuul/config-project: true`
		`- fedora-zuul-jobs`
		`- - test-python-package-zuul-workflow`
		`+ - test-python-package-zuul-workflow:`
		`+ zuul/include: []`
		`- rpms/python-gear:`
		`connection: src.fedoraproject.org`
		`+ zuul/include: []`
		`- rpms/python-zuul-sphinx:`
		`connection: src.fedoraproject.org`
		`+ zuul/include: []`
		`- rpms/nodepool:`
		`connection: src.fedoraproject.org`
		`+ zuul/include: []`

fbo commented 4 years ago

Do no include Zuul conf from package repo

We do not expect to have Zuul load configuration elements
from distgits repositories. If such repos contains a .zuul.yaml
Zuul will not load it.

zuul commented 4 years ago

Build succeeded.

config-check : SUCCESS in 40s

apevec commented 4 years ago

I missed WHY part in the commit message

rebased onto 55baddf

4 years ago

zuul commented 4 years ago

Build succeeded.

config-check : SUCCESS in 31s

Metadata Update from @fbo:
- Pull-request tagged with: gateit

4 years ago

zuul commented 4 years ago

Build succeeded (gate pipeline).

config-check : SUCCESS in 38s

Pull-Request has been merged by zuul

4 years ago

fbo commented 4 years ago

@apevec yes it deserved a better commit message. I've updated it.

apevec commented 4 years ago

sorry for being dense, I still don't get it: why wouldn't some distgit have specific Zuul jobs if they wish?

fbo commented 4 years ago

We had bad experiences with some unexpected .zuul.yaml or .zuul.d in repositories branches especially on github when people open PR from local branches. With Github protected branch option that's no longer an issue now) but with Pagure we don't have this option.

So better to prevent Zuul to read its config from distgit by default. But obviously it makes sense to allow it when needed and as you can that's actionable by repository.