From bdad3ffbb9acee7899693d14a6d35d02f4a98289 Mon Sep 17 00:00:00 2001 From: Ben Cotton Date: May 18 2020 16:44:31 +0000 Subject: [PATCH 1/2] Add a proposed Feedback section This section would prompt Change Owners to explictly incorporate community feedback in the body of the proposal. This can be helpful to give a clear indication of why certain ideas were rejected both for history's sake and to expedite the FESCo voting process. This section was suggested by churchyard with inspiration from Python's PEP-0001. --- diff --git a/modules/ROOT/pages/changes_guide.adoc b/modules/ROOT/pages/changes_guide.adoc index d9a7a97..1a3d5e2 100644 --- a/modules/ROOT/pages/changes_guide.adoc +++ b/modules/ROOT/pages/changes_guide.adoc @@ -60,6 +60,16 @@ Do not edit this section except to set the target release version and update the === Detailed Description Expand on the summary, if appropriate. A couple sentences suffices to explain the goal, but the more details you can provide the better. +If there are multiple reasonable approaches, you should indicate why you declined to use the others. + +=== Feedback +Summarize the feedback from the community and address why you chose not to accept proposed alternatives. +This section is optional for all change proposals, but is strongly suggested. +Incorporating feedback here as it is raised gives FESCo a clearer view of your proposal and leaves a good record for the future. +This section is inspired in part by the "Rejected Ideas" section described by https://www.python.org/dev/peps/pep-0001/#id46[PEP-0001]. + +TIP: You should fill in this section as feedback is received. +As this is optional the Program Manager does not need to wait for you to complete this section before submitting to FESCo. === Benefit to Fedora diff --git a/modules/ROOT/pages/changes_policy.adoc b/modules/ROOT/pages/changes_policy.adoc index 057fc35..e2564ad 100644 --- a/modules/ROOT/pages/changes_policy.adoc +++ b/modules/ROOT/pages/changes_policy.adoc @@ -53,6 +53,7 @@ System-wide changes involve system-wide defaults, critical path components, or o |Owner|required|required |Current status|required|required |Detailed description|required|required +|Feedback|optional|optional |Benefit to Fedora|required|required |Scope/Proposal owners|required|required |Scope/Other developers|as applicable|required From 5bbb344e85b6d4f8e6d80003ed8d31f4c575bb22 Mon Sep 17 00:00:00 2001 From: Ben Cotton Date: May 18 2020 16:44:31 +0000 Subject: [PATCH 2/2] Add some more guidance for the controversial proposals as suggested by churchyard --- diff --git a/modules/ROOT/pages/changes_guide.adoc b/modules/ROOT/pages/changes_guide.adoc index 1a3d5e2..6f1f7bf 100644 --- a/modules/ROOT/pages/changes_guide.adoc +++ b/modules/ROOT/pages/changes_guide.adoc @@ -66,10 +66,18 @@ If there are multiple reasonable approaches, you should indicate why you decline Summarize the feedback from the community and address why you chose not to accept proposed alternatives. This section is optional for all change proposals, but is strongly suggested. Incorporating feedback here as it is raised gives FESCo a clearer view of your proposal and leaves a good record for the future. +If you get no feedback, that is useful to note in this section as well. This section is inspired in part by the "Rejected Ideas" section described by https://www.python.org/dev/peps/pep-0001/#id46[PEP-0001]. +For innovative or possibly controversial ideas, consider collecting feedback before you file the change proposal. +This could be done via a post to the devel mailing list for full community feedback, or sharing with some additional people who you trust to give you candid feedback. +//In thie future, there will be more specific guidance about how to post pre-proposal feedback. +Either way, when you receive feedback, you should summarize it in this section. + TIP: You should fill in this section as feedback is received. As this is optional the Program Manager does not need to wait for you to complete this section before submitting to FESCo. +If the discussion gets heated, consider asking a neutral party to summarize the discussions for you. +This helps avoid bias and emotional response. === Benefit to Fedora