#2 WIP: Add a proposed Feedback section
Merged by bcotton. Opened by bcotton.
change_feedback  into  master

Download 2.patch

This section would prompt Change Owners to explictly incorporate community feedback in the body of the proposal. This can be helpful to give a clear indication of why certain ideas were rejected both for history's sake and to expedite the FESCo voting process.

This section was suggested by churchyard with inspiration from Python's PEP-0001.

@churchyard here's a first draft for you. Does this match your expectations from our discussion?

Yes, this is pretty much it. (I also wanted to encourage ideas, but making it clear that ideas are not approved, but only discussed -- that is however a different problem to solve.)

From the text it is also unclear when should be the feedback section created. I suggest to add something like:

For innovative or possibly controversial ideas, consider collection feedback before you file the change proposal. Either way, when you receive feedback (both before or after the change was proposed), you should summarize it in this section. Sometimes, there is no feedback, and it is fine to acknowledge that here. Some other times, the discussions can get heated: consider asking a neutral party to summarize the discussions in such case to avoid bias.

Instead of the current

TIP: You should fill in this section as feedback is received.

1 new commit added

  • Add some more guidance for the controversial proposals as suggested by churchyard

Thanks for the feedback!

Yes, this is pretty much it. (I also wanted to encourage ideas, but making it clear that ideas are not approved, but only discussed -- that is however a different problem to solve.)

Agreed. I intentionally split this up so that we can handle them separately.

From the text it is also unclear when should be the feedback section created. I suggest to add something like:

I kept the TIP as-is, but I folded your suggested text into the section. Does this look reasonable to you?

I intentionally split this up so that we can handle them separately.

I thought so, but just wanted to make this clear in case the second part was somewhat lost. Thank you.

The change looks good.

What happened on this line?
(Is it meant to be commented out? Are double slash comments valid in AsciiDoc?)
Also, "thie".

(Is it meant to be commented out? Are double slash comments valid in AsciiDoc?)

Yes, it is a valid AsciiDoc comment. It's an admission that I'm telling people to do something without providing much guidance.

Also, "thie".

WONTFIX typos in comments :smile:

rebased onto bdad3ffbb9acee7899693d14a6d35d02f4a98289

Pull-Request has been merged by bcotton

Metadata