PR#149: fedora-cert: Fix username in kinit command example - fedora-packager

fedora-packager

#149 fedora-cert: Fix username in kinit command example

Merged 7 years ago by puiterwijk. Opened 7 years ago by tmz.

tmz/fedora-packager master into master

fedora-cert: Fix username in kinit command example

Todd Zullinger • 7 years ago

aad8c05

src/fedora-cert.py

file modified

+1 -1

		`@@ -37,7 +37,7 @@`
		`with open(os.path.expanduser('~/.fedora.upn'), 'w') as f:`
		`f.write(username)`
		`print('Kerberos username configured. Run kinit %s@FEDORAPROJECT.ORG' %`
		`- opts.username)`
		`+ username)`
		`sys.exit(0)`

		`#has cert expired? do we force a new cert? get a new one`

tmz commented 7 years ago

When running fedora-cert --configure-krb the code uses the username
variable to write the ~/.fedora.upn file but uses opts.username in the
output.

The username may not have been explicitly passed as an option, in which
case opts.username is False. The username is derived from an existing
or newly generated certificate if not provided.

This causes potentially misleading output for the suggested kinit
command:

[tmz@localhost ~]$ fedora-cert --configure-krb
Kerberos username configured. Run kinit False@FEDORAPROJECT.ORG

[tmz@localhost ~]$ cat ~/.fedora.upn
tmz