PR#812: Use GCE guest environment instead of cloud-init - fedora-kickstarts

fedora-kickstarts

#812 Use GCE guest environment instead of cloud-init

Merged 4 years ago by dustymabe. Opened 4 years ago by ericedens.

ericedens/fedora-kickstarts main into main

Use GCE guest environment instead of cloud-init

Eric Edens • 4 years ago

d6965a2

fedora-cloud-base-gcp.ks

file modified

		`@@ -11,7 +11,14 @@`
		`# https://cloud.google.com/compute/docs/import/import-existing-image`
		`bootloader --timeout=0 --append="no_timer_check net.ifnames=0 console=ttyS0,38400n8d"`

		+ # redefine `services` here to drop cloud-init systemd unit enablements from
		`+ # fedora-cloud-base.ks since we don't use them.`
		`+ services --enabled=sshd`
		`+`
		`%packages`
		`+ # GCP provides its own guest environment.`
		`+ +google-compute-engine-guest-configs`
		`+ -cloud-init`
		`# Fedora Cloud Base includes the qemu guest agent. GCP prefers`
		`# that it not be installed https://pagure.io/cloud-sig/issue/319`
		`-qemu-guest-agent`

ericedens commented 4 years ago

Updates fedora-cloud-base-gcp.ks with the following changes:
- Don't enable cloud-init services
- Don't install cloud-init
- Install top-level GCE guest environment package

ericedens commented 4 years ago

Any tips on building this locally? Or how to submit it to a remote build fleet?

siosm commented 4 years ago

Maybe @dustymabe ?

dustymabe commented on line 5 of fedora-cloud-base-gcp.ks 4 years ago

This is already enabled in fedora-cloud-base.ks so not needed here.

dustymabe commented on line 5 of fedora-cloud-base-gcp.ks 4 years ago

Ahh, I see. You do this here to get rid of the cloud-init service enablement. from the base file. Maybe add a comment here like:

# redefine `services` here to drop cloud-init systemd unit enablements from
# fedora-cloud-base.ks since we don't use them.
services --enabled=sshd

```

dustymabe commented 4 years ago

Any tips on building this locally? Or how to submit it to a remote build fleet?

Check out the virt-install command in https://lists.fedoraproject.org/archives/list/cloud@lists.fedoraproject.org/message/WY4KFAFWAV272YN2DKXEN5IG7DHG4DUL/

I thought I had got you set up last year to be able to build images locally. Once we merge this we can check the nightly rawhide and see how it looks too.

ngompa commented 4 years ago

I think this gets done through ImageFactory/Oz now, and I'm not sure how you run that locally...

ngompa commented 4 years ago

Otherwise, this looks good.

:thumbsup:

rebased onto b83166755ac5dec897f744a713441bc3d9740506

4 years ago

rebased onto d6965a2

4 years ago

ericedens commented 4 years ago

@dustymabe -- Added the comment for services.

I couldn't find the notes I'd take from last time; if you're alright with merging, I can test the rawhide nightly. Otherwise, I can re-visit early next week to build locally. Let me know!

dustymabe commented 4 years ago

LGTM