#737 include and enable qemu-guest-image [cloud-sig issue #319]
Merged 3 months ago by dustymabe. Opened 4 months ago by davdunc.
https://pagure.io/forks/davdunc/fedora-kickstarts.git origin/issue-319  into  main

Improve ambiguous comment per review
David Duncan • 3 months ago  
uncomment packages section
David Duncan • 4 months ago  
Enable qemu-guest-agent on cloud, not GCP. cloud-sig/issue/319
David Duncan • 4 months ago  
fedora-cloud-base-gcp.ks
file modified
+5 -2
@@ -11,8 +11,11 @@

  # https://cloud.google.com/compute/docs/import/import-existing-image

  bootloader --timeout=0 --append="no_timer_check net.ifnames=0 console=ttyS0,38400n8d"

  

- #%packages

- #%end

+ %packages

+ # Fedora Cloud Base includes the qemu guest agent. GCP prefers

+ # that it not be installed  https://pagure.io/cloud-sig/issue/319

+ -qemu-guest-agent

+ %end

  

  %post --erroronfail

  cat <<EOF > /etc/NetworkManager/conf.d/gcp-mtu.conf

fedora-cloud-base.ks
file modified
+6
@@ -67,6 +67,12 @@

  # rhgb/quiet on kernel command line

  -plymouth

  

+ # Install qemu-guest-agent https://pagure.io/cloud-sig/issue/319 To

+ # improve the integration with OpenStack and other VM management

+ # systems (oVirt, KubeVirt).

+ qemu-guest-agent

+ 

+ 

  # No need for firewalld for now. We don't have a firewall on by default.

  -firewalld

  

no initial comment

This PR adds the qemu-guest-agent to the base image for the fedora-cloud-base and then for the GCP image, it ensures that the package is not enabled for the ks.cfg generated for the fedora-cloud-base-gcp.

FROM the Meeting Notes:
since the unit appears to be inert on any system that can't
take advantage of the service, we propose to add qemu-guest-agent to
the base package set. We won't include it on GCP since we have a
separate image for GCP already. In the future we may make other
images specific to cloud providers, in which case we'll also remove
it from those variants. (dustymabe, 16:20:33)

P.S. This is my first commit to the kickstarts, so I would appreciate a more thorough review

Overall it looks fine, if the service should be enabled by default you'll also need a separate PR to enable the service preset in fedora-release, you'll likely want a 80-cloud.preset there.

the last bit after the comma seems a bit confusing to me. How about we drop it and change the first word from Enable to Install?

# Install qemu-guest-agent https://pagure.io/cloud-sig/issue/319 to
# improve the integration with OpenStack and other VM management
# systems (oVirt, KubeVirt).

```

Overall it looks fine, if the service should be enabled by default you'll also need a separate PR to enable the service preset in fedora-release, you'll likely want a 80-cloud.preset there.

Thanks for the helpful comment here!

I checked it out and it's already enabled in the presets. The service also has the nice feature of only actually being activated if the platform (or user) enabled the unix socket via something like

virt-install --channel unix,mode=bind,target_type=virtio,name='org.qemu.guest_agent.0'

So on platforms where it can't or won't be used the service won't run.

Thanks to both of you. apologies for the long delay. I have updated the branch with the changes: https://pagure.io/fork/davdunc/fedora-kickstarts/c/1e02ceba06a390633fce61bdc9a5eb47653aefa1?branch=origin%2Fissue-319

Not sure if I have to do anything else to update the PR.

1 new commit added

  • Improve ambiguous comment per review
3 months ago

Pull-Request has been merged by dustymabe

3 months ago

Thanks! Where/when can I test the resulting guest image, @dustymabe ?