#660 Revert "remove systemd package from fedora-container-base"
Merged 3 years ago by mohanboddu. Opened 3 years ago by bowlofeggs.
bowlofeggs/fedora-kickstarts releng-9603  into  f32

@@ -26,6 +26,11 @@ 

  # https://pagure.io/atomic-wg/issue/308

  printf "tsflags=nodocs\n" >>/etc/dnf/dnf.conf

  

+ # https://bugzilla.redhat.com/show_bug.cgi?id=1576993

+ systemctl disable dnf-makecache.timer

+ 

+ #Mask mount units and getty service so that we don't get login prompt

+ systemctl mask systemd-remount-fs.service dev-hugepages.mount sys-fs-fuse-connections.mount systemd-logind.service getty.target console-getty.service

  

  # https://bugzilla.redhat.com/show_bug.cgi?id=1343138

  # Fix /run/lock breakage since it's not tmpfs in docker
@@ -39,6 +44,7 @@ 

  #   [/usr/lib/tmpfiles.d/systemd.conf:26] Failed to replace specifiers: /run/log/journal/%m

  #

  umount /run

+ systemd-tmpfiles --prefix=/run/ --prefix=/var/run/ --create --boot || true

  rm /run/nologin # https://pagure.io/atomic-wg/issue/316

  

  # Final pruning

@@ -38,6 +38,8 @@ 

  shadow-utils

  sssd-client

  util-linux

+ # needed by Anaconda https://bugzilla.redhat.com/show_bug.cgi?id=1744115

+ systemd

  -kernel

  -dosfstools

  -e2fsprogs

This reverts commit 57e13a1.

I noticed that systemd-logind was causing problems in our
containers after a container rebuild of the f32 base image was
published about 5 days ago. I found that an issue[0] had been
filed about the problem, but that bug was reported against
Rawhide (f33). I then found that systemd had been removed from
the f32 base image after f32 was released.

This causes problems for users who expect stability out of Fedora
releases - changing the default package set means that a container
build that works one day can break the next. In our case, the
problem wasn't so much that systemd was removed, but that the unit
masks were removed. This causes some components of systemd to be
unable to function in a container, and puts a burden on users to
identify the problem.

https://pagure.io/releng/issue/9603

[0] https://bugzilla.redhat.com/show_bug.cgi?id=1841139

Pull-Request has been merged by mohanboddu

3 years ago

Please hold the horses. The damage has been done, image is out there, people have put workarounds already. Do we want them to remove the workarounds again?

Not everyone has put in workarounds. It took me several hours to figure out what I needed to do. The longer we wait on merging this, the more people will have to spend time figuring out why their images broke.

Rawhide is the right place for changes like this. In stable releases it is a regression. When we introduce regressions, we should fix them.