PR#553: remove legacy swap - fedora-kickstarts

fedora-kickstarts

#553 remove legacy swap

Merged 4 years ago by mohanboddu. Opened 4 years ago by chrismurphy.

Unknown source devel2 into master

chris • 4 years ago

b05c635

fedora-live-base.ks

file modified

+1 -7

		`@@ -108,13 +108,7 @@`
		`fi`
		`done`

		`- # enable swaps unless requested otherwise`
		- swaps=\`blkid -t TYPE=swap -o device\`
		- if ! strstr "\`cat /proc/cmdline\`" noswap && [ -n "\$swaps" ] ; then
		`- for s in \$swaps ; do`
		`- action "Enabling swap partition \$s" swapon \$s`
		`- done`
		`- fi`
		`+ # enable swapfile if it exists`
		if ! strstr "\`cat /proc/cmdline\`" noswap && [ -f /run/initramfs/live/\${livedir}/swap.img ] ; then
		`action "Enabling swap file" swapon /run/initramfs/live/\${livedir}/swap.img`
		`fi`

chrismurphy commented 4 years ago

Now that Anaconda enables swap on zram by default, we don't need to enable any legacy swap LVs or partitions. But per conversation with livecd-tools, keep the activation of swapfile created by livecd-iso-to-disk --swap-size-mb

https://github.com/rhinstaller/anaconda/pull/2039
https://github.com/livecd-tools/livecd-tools/issues/133

kevin commented 4 years ago

@catanzaro @hadess

Can you all review this and confirm you are on the same zram page? Thanks.

catanzaro commented 4 years ago

@kevin we discussed this at today's WG meeting. Indeed, we want to revert this because the zram for live media goal is already achieved in a different way after Chris's change to anaconda.

We're going to continue to separately pursue enabling zram for installed systems.

kevin commented 4 years ago

I'm not sure I parse that right... should we close this PR or merge it?