#49 jam: remove retired lv2-fil-plugins
Merged 7 years ago by bruno. Opened 7 years ago by adamwill.
adamwill/fedora-kickstarts jam-remove-lv2  into  master

file modified
-1
@@ -108,7 +108,6 @@ 

  #lv2 plugins

  lv2

  lv2-avw-plugins

- lv2-fil-plugins

  lv2-invada-plugins

  lv2-kn0ck0ut

  lv2-ll-plugins

was retired for broken dependencies, no-one has fixed it.

note, this should go to f25 as well as master.

You should to the f25 pull request. Make sure your f25 branch in your fork is up to date with f25, git cherry-pick the commit, push to your repo and then create a new pull request from f25 to f25. I am not sure if we want to apply it to f25 right now, even though it is very safe. But I'll approve the request for master.

Pull-Request has been merged by bruno

7 years ago

L thought you were a different Adam. You can approve PRs yourself. I'm also going to assume that this request is OK with QA and get the change in f25 incase there is a compose tonight that might still pick it up.

@bruno I know I can, but kevin and dennis say they'd still prefer committers go through the PR process. and yes, please send it to f25 too - mainly so it'll make Alpha when we do it.

A rebased version of the patch has been applied to the f25 branch.

Double check with Dennis and Kevin if they (always) want someone different to approve PRs than submit them. For simple ones that only affect games (or in this case jam), I make a PR but approve it myself. For more complicated stuff I would let it sit for review. If that isn't the correct process, I'd like to know.

All commits should be reviewed by someone else. no one should be merging their own commits. juts to make sure everything has an extra set of eyes on it

Thanks for the clarification. I will follow that process.

Metadata