PR#1026: [f40] container-toolbox: Use 'toolbx' as VARIANT_ID in os-release(5) - fedora-kickstarts

fedora-kickstarts

#1026 [f40] container-toolbox: Use 'toolbx' as VARIANT_ID in os-release(5)

Merged 2 months ago by ngompa. Opened 2 months ago by rishi.

rishi/fedora-kickstarts wip/rishi/toolbx-fedora-release-toolbx-f40 into f40

container-toolbox: Use 'toolbx' as VARIANT_ID in os-release(5)

Debarshi Ray • 2 months ago

82222e1

fedora-container-toolbox.ks

file modified

+1 -1

		`@@ -33,7 +33,7 @@`
		`dnf-plugins-core`
		`-dosfstools`
		`-e2fsprogs`
		`- fedora-release-container`
		`+ fedora-release-toolbx`
		`findutils`
		`flatpak-spawn`
		`fpaste`

rishi commented 2 months ago

This is meant to distinguish OCI containers and images that are designed
specifically for Toolbx from others. Toolbx containers are long-lasting
pet containers for interactive command line use, which makes them
substantially different from short-lived containers running services.

Therefore, it can be useful to be able to identify Toolbx containers and
images when generating statistics about Fedora usage.

https://pagure.io/Fedora-Council/tickets/issue/449

rebased onto 4536bf7

2 months ago

rishi commented 2 months ago

Corresponding pull request for main: https://pagure.io/fedora-kickstarts/pull-request/1015

I had failed to realize that it landed only in main, not f40.

rishi commented 2 months ago

It looks like the fedora-toolbox images are still being built by Image Factory, not KIWI:

$ podman inspect --format '{{ .Comment }}' --type image registry.fedoraproject.org/fedora-toolbox:40
Created by Image Factory

... which is why I filed this PR.

kevin commented 2 months ago

We are in beta freeze. Is this important to try and get in before that? or can it land after we sign off on beta?

rishi commented 2 months ago

We are in beta freeze. Is this important to try and get in before that? or can it land after we sign off on beta?

It's not that urgent, and can definitely land after the Beta Freeze.

kevin commented 2 months ago

Oh, and if we move to kiwi doing these builds, it will need to change over there.... but we can sort it out.

rishi commented 2 months ago

Oh, and if we move to kiwi doing these builds, it will need to change over there.... but we can sort it out.

Yeah, I am trying to sort out the KIWI builds in parallel. I got myself a thin slice of free time to work on the fedora-toolbox images, and I want to take advantage of it to fix everything, so that nothing slips through the cracks.

rishi commented 2 months ago

Oh, and if we move to kiwi doing these builds, it will need to change over there.... but we can sort it out.

Yeah, I am trying to sort out the KIWI builds in parallel. I got myself a thin slice of free time to work on the fedora-toolbox images, and I want to take advantage of it to fix everything, so that nothing slips through the cracks.

For example, what if something goes wrong and we have to activate the contingency plan and switch back to Image Factory?