#307 Kinoite - add Adwaita theme for GTK2 apps and flatpaks
Closed: Fixed a year ago by siosm. Opened a year ago by frginm.

Can we have Adwaita GTK2 for legacy flatpaks? In theory more and more older apps can and will be wrapped by flatpak. KDE allows setting GTK application style to "Default" which makes Adwaita available.

This is a request to add adwaita-gtk2-theme and breeze-gtk to base Kinoite.

This is also an implicit request to pull-in GTK2 and related deps as well.

See [1] for before and after screenshots using Kinoite 37 and Flathub GIMP.

[1] https://fedoraproject.org/wiki/AdwaitaGtk2Kinoite


If we were to preload anything, it'd be only the Breeze GTK 2 theme.

Metadata Update from @ngompa:
- Issue tagged with: experience, kinoite

a year ago

If we were to preload anything, it'd be only the Breeze GTK 2 theme.

Are there plans to remove Adwaita in Fedora KDE? I assumed with Kinoite being Workstation adjacent that Adwaita compatibility would be a good thing?

I for one am using KDE's Adwaita theme to help test some Python Qt GUI widgets under "vanilla" GNOME and KDE themes. Having both available out of the box on Kinoite lets me do some really basic sanity testing regarding UX. It's also the reason it seems missing from Flathub GIMP.

Observation. After rpm-ostree reset GIMP still picks up Adwaita theme. I'm guessing GNOME Flathub runtime provides GTK2?

It looks like the GTK2 parts from breeze-gtk-gtk2 actually generate GTK2 compatible gtkrc?

There's a new file:

$ ll -a ~

-rw-r--r--. 1 user user    0 Feb 19 15:50 .gtkrc-2.0
-rw-r--r--. 1 user user  314 Feb 19 16:14 .gtkrc-2.0-kde4

$ cat ~/.gtkrc-2.0-kde4

gtk-enable-animations=1
gtk-primary-button-warps-slider=0
gtk-toolbar-style=3
gtk-menu-images=1
gtk-button-images=1
gtk-cursor-theme-size=24
gtk-cursor-theme-name="breeze_cursors"
gtk-icon-theme-name="breeze"
gtk-font-name="Noto Sans,  10"
include "/usr/share/themes/Adwaita/gtk-2.0/gtkrc"

gtk-theme-name="Adwaita"

Observation. Tried booting with just breeze-gtk letting Plasma genereate fresh gtkrc.

Even with wiping gtkrc and fresh login, the kcm seems unable to generate a valid GTK2 Breeze theme?

Repeat (nuke gtkrc and fresh login) for all application themes "Breeze" / "Default" / "Emacs"

Observation. Changing GTK2 theme enough times using the GUI seems to "softlock" into an invalid gtkrc. Eventually only Raleigh available in GIMP.

Observation. I cannot actually generate a valid GTK2 Breeze theme gtkrc with the GUI 🫠

Themes for Flatpak apps should be provided by Flatpak, not the host. Not sure why this is broken for GIMP but I can reproduce it. Looks like it's not picking the right theme.

We also already have breeze-gtk-gtk3 & breeze-gtk-gtk4 installed by default.

See [1] for before and after screenshots using Kinoite 37 and Flathub GIMP.

[1] https://fedoraproject.org/wiki/AdwaitaGtk2Kinoite

You should probably avoid abusing the Wiki to upload screenshots and use another hosting service for that.

I think the problem here is a non-existent org.gtk.Gtk2theme.Breeze

Metadata Update from @siosm:
- Issue close_status updated to: Deferred to upstream
- Issue status updated to: Closed (was: Open)

a year ago

Metadata Update from @siosm:
- Issue status updated to: Open (was: Closed)

a year ago

I've just realized that we explicitly remove adwaita-gtk2-theme in Kinoite compared to the KDE Spin. Does adding adwaita-gtk2-theme on Kinoite make the problem go away?

Looks like it does from the screenshots. I'll re-ad it to Kinoite until we find a better solution.

Will be done with https://pagure.io/workstation-ostree-config/pull-request/367 for F39. Will backport to F38 at minimum.

Metadata Update from @siosm:
- Issue assigned to siosm

a year ago

Metadata Update from @siosm:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

a year ago

Login to comment on this ticket.

Metadata
Boards 1
Kinoite Status: Done