The page https://fedoraproject.org/PackageReviewStatus/ seems to have stopped being updated.
It currently displays: Last updated: 2021-05-25 20:00:20 UTC (v6.0.4).
Last updated: 2021-05-25 20:00:20 UTC (v6.0.4).
That's 3 days ago, and if I'm not wrong, this page used to be updated several times a day.
Looking at this CronJob (https://pagure.io/fedora-infra/ansible/blob/main/f/roles/openshift-apps/review-stats/templates/cron.yml), I understand it should be updated every hour, no?
Is the update broken, or just less frequent?
Low urgency probably
It was hitting a traceback:
Traceback (most recent call last): File "/usr/local/bin/review-stats", line 11, in <module> load_entry_point('review-stats==6.0.4', 'console_scripts', 'review-stats')() File "/usr/lib/python3.7/site-packages/click/core.py", line 829, in __call__ return self.main(*args, **kwargs) File "/usr/lib/python3.7/site-packages/click/core.py", line 782, in main rv = self.invoke(ctx) File "/usr/lib/python3.7/site-packages/click/core.py", line 1259, in invoke return _process_result(sub_ctx.command.invoke(sub_ctx)) File "/usr/lib/python3.7/site-packages/click/core.py", line 1066, in invoke return ctx.invoke(self.callback, **ctx.params) File "/usr/lib/python3.7/site-packages/click/core.py", line 610, in invoke return callback(*args, **kwargs) File "/usr/lib/python3.7/site-packages/click/decorators.py", line 21, in new_func return f(get_current_context(), *args, **kwargs) File "/usr/local/lib/python3.7/site-packages/review_stats/scripts/review_stats.py", line 101, in make_pages new_tickets = utils.get_reviewable(ctx.obj['bz_tickets']) File "/usr/local/lib/python3.7/site-packages/review_stats/utils.py", line 189, in get_reviewable tklist = [tk for tk in tklist if tk.review_flag_status == '' File "/usr/local/lib/python3.7/site-packages/review_stats/utils.py", line 191, in <listcomp> and not tk.hidden File "/usr/local/lib/python3.7/site-packages/review_stats/models.py", line 118, in hidden self.legal_issues or self.needinfo or self.needinfo_reviewer or File "/usr/local/lib/python3.7/site-packages/review_stats/models.py", line 140, in needinfo and flag['requestee'] == self.bug.creator): KeyError: 'requestee'
Also, it's act on bugs has been tracebacking:
Traceback (most recent call last): File "/usr/local/lib/python3.7/site-packages/review_stats/utils.py", line 283, in set_needinfo bz.update_bugs([tk.bug.id], update) File "/usr/lib/python3.7/site-packages/bugzilla/base.py", line 1326, in update_bugs return self._proxy.Bug.update(tmp) File "/usr/lib64/python3.7/xmlrpc/client.py", line 1112, in __call__ return self.__send(self.__name, args) File "/usr/lib/python3.7/site-packages/bugzilla/transport.py", line 104, in _ServerProxy__request self)._ServerProxy__request(methodname, params) File "/usr/lib64/python3.7/xmlrpc/client.py", line 1452, in __request verbose=self.__verbose File "/usr/lib/python3.7/site-packages/bugzilla/transport.py", line 202, in request return self._request_helper(url, request_body) File "/usr/lib/python3.7/site-packages/bugzilla/transport.py", line 180, in _request_helper return self.parse_response(response) File "/usr/lib/python3.7/site-packages/bugzilla/transport.py", line 154, in parse_response return unmarshaller.close() File "/usr/lib64/python3.7/xmlrpc/client.py", line 656, in close raise Fault(**self._stack[0]) xmlrpc.client.Fault: <Fault 132: "The flag 'needinfo' has been set multiple times. You must specify the id value to update the flag."> Traceback (most recent call last): File "/usr/local/bin/review-stats", line 11, in <module> load_entry_point('review-stats==6.0.4', 'console_scripts', 'review-stats')() File "/usr/lib/python3.7/site-packages/click/core.py", line 829, in __call__ return self.main(*args, **kwargs) File "/usr/lib/python3.7/site-packages/click/core.py", line 782, in main rv = self.invoke(ctx) File "/usr/lib/python3.7/site-packages/click/core.py", line 1259, in invoke return _process_result(sub_ctx.command.invoke(sub_ctx)) File "/usr/lib/python3.7/site-packages/click/core.py", line 1066, in invoke return ctx.invoke(self.callback, **ctx.params) File "/usr/lib/python3.7/site-packages/click/core.py", line 610, in invoke return callback(*args, **kwargs) File "/usr/lib/python3.7/site-packages/click/decorators.py", line 21, in new_func return f(get_current_context(), *args, **kwargs) File "/usr/local/lib/python3.7/site-packages/review_stats/scripts/review_stats.py", line 216, in work_on_bugs for tk in utils.get_needinfo_since(not_approved_tickets, needinfo_waiting_days, 'submitter'): File "/usr/local/lib/python3.7/site-packages/review_stats/utils.py", line 171, in get_needinfo_since if user == 'submitter' and not tk.needinfo: File "/usr/local/lib/python3.7/site-packages/review_stats/models.py", line 140, in needinfo and flag['requestee'] == self.bug.creator): KeyError: 'requestee'
Then in the last few hours that cleared up (Probibly the problem bug was closed/moved).
@mattia Should we try and make this more robust? :)
Should we try and make this more robust?
Yep, I always banged my head against a brick wall with those flags error...
@kevin I've opened https://pagure.io/fedora-infra/review_stats/pull-request/11 to try to reduce these errors.
BTW, it seems that the cron script that syncs staging review_stats content to sundries is not running, I can see the script is running in staging OS, but the staging web pages are not updated since last year :(
It's getting permission denied errors:
PermissionError: [Errno 13] Permission denied: '/review-stats/index.html'
I corrected the uid and it should update next run hopefully. :)
Metadata Update from @asaleh: - Issue tagged with: medium-gain, medium-trouble, ops
Metadata Update from @asaleh: - Issue priority set to: Waiting on Reporter (was: Needs Review)
So, I've pushed the above changes to staging. I'll let it run for a couple of days there, if no errors pop out I'll push those to prod.
Thanks @kevin, I confirm staging web pages are now updated again!
Great. i am going to close this out then since things are all running again and hopefully will be more reliable soon too!
Metadata Update from @kevin: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.