Describe what you would like us to do:

Hello, FESCo has approved the following:

Using "Block Un-Signed commits" hook in dist-git is not allowed.
We'll ask dist-git admins to mass-disable the hook in all dist-git repos. If not possible, we declare that anybody who is affected by this hook can request disabling it in a specific repo via a ticket.
We'll ask dist-git admins to disallow the hook in dist-git / remove it from the list of available hooks. If not possible, see above.

Hence, I am opening this ticket, to ask just that.

Is it possible to mass disable the "Block Un-Signed commits" hook in dist-git? If it is, please do so.
Is it possible to not allow maintainers to re-enable it or to remove the hook from src.fp.o entirely? If it is, please do so.

If neither is possible, let me know and we'll figure out the next best thing.

Thanks.

When do you need this to be done by? (YYYY/MM/DD)

No particular deadline.

Metadata Update from @pingou:
- Issue assigned to pingou

3 years ago

pingou commented 3 years ago

Is it possible to mass disable the "Block Un-Signed commits" hook in dist-git? If it is, please do so.

Pretty sure that's doable directly via the DB. Would you have by any chances a project that turned on that setting?

Is it possible to not allow maintainers to re-enable it or to remove the hook from src.fp.o entirely? If it is, please do so.

This is a simple configuration change to push out.

Metadata Update from @pingou:
- Issue priority set to: Waiting on Assignee (was: Needs Review)
- Issue tagged with: high-gain, medium-trouble, ops

3 years ago

pingou commented 3 years ago

Commit 9d4f6c76 relates to this ticket

pingou commented 3 years ago

Is it possible to mass disable the "Block Un-Signed commits" hook in dist-git? If it is, please do so.

Pretty sure that's doable directly via the DB. Would you have by any chances a project that turned on that setting?

Database side, I only see two (which seems unactive):

pagure=# select * from hook_pagure_unsigned_commit;
 id | project_id | active 
----+------------+--------
  3 |       7809 | f
  4 |      24685 | f
(2 rows)

pagure=# select name, namespace from projects where id in (7809,24685);
       name       | namespace 
------------------+-----------
 plexus-languages | rpms
 knot-resolver    | rpms

Edited 3 years ago by pingou