#9693 Ansible Cleanup: Apprentice Friendly: Remove PHX2 from playbooks
Closed: Fixed 2 years ago by mohanboddu. Opened 3 years ago by smooge.

Describe what you would like us to do:

There are still many references to PHX2 and its networks in the ansible playbooks. These should be able to be safely removed for ease of maintenance:

Tasks for an apprentice
1. Make a fork of the https://pagure.io/fedora-infra/ansible/
2. Go through the playbooks and look for entries which mention phx2.fedoraproject.org, PHX2, or 10.5.x.x networks.
3. Look at the section and see if it makes sense to do one of the following:
a. remove the mention.
b. change the mention to IAD2
c. move the mention to documentation.
4. Make a branch per section changed (aka only change a role or playbook at a time).
5. Make the changes and then make a PR to main ansible
6. Get feedback and/or move to the next one.


When do you need this to be done by? (YYYY/MM/DD)



Metadata Update from @mohanboddu:
- Issue priority set to: Waiting on Assignee (was: Needs Review)
- Issue tagged with: low-gain, low-trouble, ops

3 years ago

Hello,

I would like to be assigned to this ticket. If needed I will ask the Fedora Infrastructure Team to give me some support.

Best regards,
Patux

Metadata Update from @smooge:
- Issue assigned to patux

3 years ago

Metadata Update from @patux:
- Assignee reset

3 years ago

I’m not interested in this issue anymore.

I let it to another person to be assigned.

Hello,

I just made a trivial change to the inventory/cloud file and created PR#479.

This is my first PR so I wanted to make sure I understood the workflow before moving on.

I created a topic branch, made my changes, pushed to my fork and created the PR.

I'm assuming the next step is to post this comment and wait for feedback.

If I'm wrong I guess I will hear about it soon enough. ;)

Thanks,
TC

@austinpowered yep. Thats exactly the right process. :)

Thanks for the PR.

So, there's a bit more to do here. (But getting close!)

Look at the output of 'git grep phx2' and you can see there's a number of comments that mention phx2 still. Also, there's a number of refrences to fas2 in phx2, which can be deleted (like the manual sync playbook for fas and some when: conditionals that have phx2 (those entire tasks can be removed since they will never match now).

Greetings,

I'm new to contributing to the Fedora Infrastructure project, and this seems to be a good way to get started. Is there a priority order to what playbooks need to be addressed when?

So, there's a bit more to do here. (But getting close!)

Look at the output of 'git grep phx2' and you can see there's a number of comments that mention phx2 still. Also, there's a number of refrences to fas2 in phx2, which can be deleted (like the manual sync playbook for fas and some when: conditionals that have phx2 (those entire tasks can be removed since they will never match now).

Does the phx2 data center no longer exist? I'm looking at vhost_reboot.yml, and the task "drain OS node if necessary" (line 62) that mentions phx2 looks like it's replicated with the "drain OS node if necessary" task at line 67. Thus, I assume it's safe to just remove the the line 62 "drain OS node if necessary" task.

https://pagure.io/fedora-infra/ansible/pull-request/631 has been submitted thanks to some guidance from nirik and adamw in IRC. This is only a small change, as I'm wanting to make sure I both understand and am executing the intended workflow properly.

Yep. That was exactly right.

The phx2 datacenter does still exist, but we have 0 machines/presense in it. All our things moved to iad2 last year...

Next on my list is the /ansible/playbooks/hosts/data-analysis01.phx2.fedoraproject.org.yml

I ran dig on the fqdn on the bastion host as well as dig for the fqdn if it had iad2.reforaproject.org, and it appears there's no A record for neither possibility of data-analysis01. If this host is no more, ought we just delete the file?

Within the playbooks directory there are two non-playbook files that reference phx2. This ticket looks like it's specifically about playbooks. Should these files be ignored?

/ansible/playbooks/manual/releng/templates/koji.conf.j2
/ansible/playbooks/manual/staging-sync/templates/koji-dc-transfer.sql

Next on my list is the /ansible/playbooks/hosts/data-analysis01.phx2.fedoraproject.org.yml

I ran dig on the fqdn on the bastion host as well as dig for the fqdn if it had iad2.reforaproject.org, and it appears there's no A record for neither possibility of data-analysis01. If this host is no more, ought we just delete the file?

Yeah, ok to delete. We just moved this over to running on log01.

Within the playbooks directory there are two non-playbook files that reference phx2. This ticket looks like it's specifically about playbooks. Should these files be ignored?

/ansible/playbooks/manual/releng/templates/koji.conf.j2

I think we want to adjust this one to iad2

/ansible/playbooks/manual/staging-sync/templates/koji-dc-transfer.sql

But this one can be removed.

Closing the ticket.

[14:04:25] <eddiejennings> https://pagure.io/fedora-infrastructure/issue/9693  Might be able to be closed now with my last PRs merged.

Metadata Update from @mohanboddu:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

2 years ago

Login to comment on this ticket.

Metadata
Boards 1
ops Status: Done
Related Pull Requests
  • #526 Merged 3 years ago
  • #507 Merged 3 years ago
  • #506 Merged 3 years ago
  • #464 Merged 3 years ago
  • #463 Merged 3 years ago
  • #458 Merged 3 years ago