#9566 No update in Bodhi is marked as critpath for Rawhide
Closed: Fixed 3 years ago by kevin. Opened 3 years ago by mattia.

Describe what you would like us to do:

Cross reference https://github.com/fedora-infra/bodhi/issues/4177

I've just filed a PR to fix Bodhi code, but the release creation process should be adapted. I don't know if it's performed manually or by some script.
When a new release is created (which becomes Rawhide), it should be created with the Release.branch property set to "master", not "fxx". When it is branched it should be changed to "fxx".

When do you need this to be done by? (YYYY/MM/DD)



Metadata Update from @mohanboddu:
- Issue priority set to: Waiting on Assignee (was: Needs Review)
- Issue tagged with: dev, low-gain, medium-trouble, ops

3 years ago

So, how useful is critpath on rawhide? As far as I know there the automatic updates don't do anything differently for it?

@adamw does qa use this status in rawhide any?

I mean, might be worth fixing, but not sure it is?

In future, I would also like to have Bodhi check user's rights to create/edit updates through a direct call to Pagure using a new hascommit endpoint (see https://pagure.io/pagure/pull-request/5087). This will make possible for collaborators to push updates on releases where they have commit access.

To make that working, we'll need to have the right branch property set for Rawhide.

Could you explain how this and 9510 are linked? I would think they would be seperate issues?

Oh, and the branch should be 'rawhide' now right?

Could you explain how this and 9510 are linked? I would think they would be seperate issues?

There's a PR in Bodhi upstream [ยน] that fixes 9510, but we cannot merge it until we're sure this ticket is fixed or it will break Rawhide updates.

Oh, and the branch should be 'rawhide' now right?

Yep.

[1] https://github.com/fedora-infra/bodhi/pull/4181

So:

bodhi releases edit --branch --name F35 --branch rawhide

?

Can I do that anytime? Or do we need to coordinate any other changes?

As a side note, should we call the rawhide branch in bodhi 'rawhide' instead of 'Fn' ? It would mean rawhide would grow over all time, but might be more clear?

bodhi releases edit --name F35 --branch rawhide
It should be safe to run whenever you want. If you want to change the name, it should be safe to do that too, but it will need to be changed again when the release is branched.

What I don't understand is if there's some script which automates the creation of a new rawhide release.
As far as I understand, the current workflow is:

  • create a new release object in Bodhi named 'F36' with branch set to 'f36'
  • change ansible vars so that 'F36' is marked as to be Rawhide and the old 'F35' is marked as branched

But we will have to:

  • create a new release object in Bodhi named 'F36' with branch set to 'rawhide'
  • edit the release object in Bodhi named 'F35' with branch set to 'f35'
  • change ansible vars so that 'F36' is marked as to be Rawhide and the old 'F35' is marked as branched

Is there an automated script which creates the release object to be adjusted, or is there a SOP describing the manual process to be changed? Just to be sure to not forget this when we will branch F35...

I think this is manual, but not 100% sure... @mohanboddu and @humaton ^ is this the case? can we adjust the SOP to use 'rawhide' as the branch and ideally 'rawhide' as the name too?

So, I think this is https://docs.pagure.org/releng/sop_mass_branching.html but it needs some work (I see pkgdb still mentioned!)

@mattia or @mohanboddu or @humaton can one of you do a PR to adjust that sop for this?

and I went and ran the bodhi commands, I guess we will see what it breaks. :)

Metadata Update from @kevin:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

3 years ago

Login to comment on this ticket.

Metadata
Boards 2
ops Status: Done
dev Status: Done