With pagure 5.12, the PR Flag API endpoint flags the commit at the top of the PR instead of the PR itself.
This makes it clearer which commit was tested.
However, it also means that using the PR Flag API endpoint instead of the commit flag API endpoint exposes the risk of a race-condition if the PR is updated before the tests have finished running (this risk was always there, pagure 5.12 will just make it more obvious).
So the toddler that flags PR based on CI results, should be ported from the PR flag API endpoint to the commit flag API endpoint.
ASAP once 5.12 is out and deployed (a beta version being already available in stg).
Metadata Update from @kevin:
- Issue priority set to: Waiting on Assignee (was: Needs Review)
- Issue tagged with: dev, low-gain, low-trouble, pagure
Metadata Update from @zlopez:
- Issue assigned to zlopez
Implemented in https://pagure.io/fedora-infra/toddlers/pull-request/66
Issue status updated to: Closed (was: Open)
Issue close_status updated to: Fixed
to comment on this ticket.