#9227 Enable force push for the rr repository
Closed: Invalid 3 years ago by pingou. Opened 3 years ago by sapatel.

Please enable force push for the rr repository. We need it temporarily.

It's not urgent but, it would be nice to have it done by the end of this week (August 14).


@sapatel I have deactivated hook preventing force push on the master branch. Can you try it and let us know how it goes?

Metadata Update from @mobrien:
- Issue tagged with: groomed, low-gain, low-trouble

3 years ago

Metadata Update from @mobrien:
- Issue priority set to: Waiting on Assignee (was: Needs Review)

3 years ago

WOah, this is a src.fedoraproject.org package?

We don't allow force push. You could re-write history and then all the hashes of what package was built from what source will be messed up. ;(

@humaton can you put this back? Hopefully they haven't pushed anything yet...

https://pagure.io/pagure-dist-git/blob/master/f/dist_git_auth.py#_161

It seems that he can't allow force pushing without editing dist-git-auth plugin

Sorry about that. We haven't pushed anything.

We thought we might be able to do it because of #4367.

Yeah, for fedorahosted we did allow projects to do that. It was their project and if they really wanted to they could shoot themselves in the foot. :)

These days, people should be doing work in forks (which DO allow force pushing). I don't know if pagure.io has an option to enable force push on the main repo or not.

That said, pagure.io and fedorahosted before it were upstream projects that could have more freedom to do what they want. src.fedoraproject.org is the permanent record of what hashes were used to build what packages. We need to it be consistent for a lot of reasons (GPL compliance, not confusing our users, ability to rebuild something we built in the past). So, we don't want to allow re-writing history there.

We do allow removing branches now, as long as no hash on that branch was used to do an official build.

pagure.io allows force pushing. The linked line is from the src.fp.o's downstream auth plugin, not from upstream vanilla pagure that runs on pagure.io. the downstream plugin is installed just on src.fp.o and centos dits-git

Yeah, for fedorahosted we did allow projects to do that. It was their project and if they really wanted to they could shoot themselves in the foot. :)

These days, people should be doing work in forks (which DO allow force pushing). I don't know if pagure.io has an option to enable force push on the main repo or not.

That said, pagure.io and fedorahosted before it were upstream projects that could have more freedom to do what they want. src.fedoraproject.org is the permanent record of what hashes were used to build what packages. We need to it be consistent for a lot of reasons (GPL compliance, not confusing our users, ability to rebuild something we built in the past). So, we don't want to allow re-writing history there.

We do allow removing branches now, as long as no hash on that branch was used to do an official build.

Ah I see, that makes sense. Thanks!

Is there anything left to do/discuss here? Otherwise I believe we can close this ticket

@sapatel has +1 my last comment, so let's close this ticket :)

Thanks everyone!

Metadata Update from @pingou:
- Issue close_status updated to: Invalid
- Issue status updated to: Closed (was: Open)

3 years ago

Login to comment on this ticket.

Metadata