#9103 Unable to open pull request on s.fp.o
Closed: Fixed 3 years ago by cipherboy. Opened 3 years ago by cipherboy.

Describe what you would like us to do:

Fix issues when opening a pull request.

I've historically been unable to open pull requests on src.fedoraproject.org. This manifests as two unrelated issues; the latter is why I've opened an issue.

  1. Open Pull Request drop down never propagates with values. I see a few HTTP requests which finish (/pv/pull-request/ready, /_dg/anitya/rpms/opencryptoki), but the values never show up. There is one error in the console:
    (index):768 Uncaught ReferenceError: process_task_results is not defined at Object.<anonymous> ((index):768) at c (jquery.min.js?version=5.10.0:2) at Object.fireWith [as resolveWith] (jquery.min.js?version=5.10.0:2) at l (jquery.min.js?version=5.10.0:2) at XMLHttpRequest.<anonymous> (jquery.min.js?version=5.10.0:2)
    This happens on F32, Firefox and Chromium. I've gotten used to working around this issue, by the following...
  2. Opening a remote-pull request now 500s. It worked last night. The error message says to contact you, so I am. :-) This is how I've worked around (1) not working on my system.

I'm trying to open a remote pull request from my fork of opencryptoki's fix-error-c-initialize branch to its master branch. I'm using the following data:
- Title: Fix segfault in C_Initialize
- Git repo address: https://src.fedoraproject.org/fork/cipherboy/rpms/opencryptoki.git or https://src.fedoraproject.org/fork/cipherboy/rpms/opencryptoki (with or without .git, both fail).
- Git branch: fix-error-c-initialize
- To branch: master

When do you need this to be done by? (YYYY/MM/DD)

Anytime that's convenient.

Metadata Update from @smooge:
- Issue priority set to: Waiting on Assignee (was: Needs Review)
- Issue tagged with: groomed, high-gain, medium-trouble, pagure

3 years ago

Is this still happening?

@pingou can you take a look?

Do you see the "Open Pull-Request" button in the fix-error-c-initialize branch when visiting https://src.fedoraproject.org/fork/cipherboy/rpms/opencryptoki/branches?branchname=master ?

I'll have to check for the remote PR workflow as this should work.

Thanks @pingou, that'll be a good workaround for now. (This change was made by the maintainer after I emailed them instead of using the PR workflow).

Yes, the Open Pull-Request button exists on the branch when visiting that URL. It seems to work fine too (redirects to a page with a diff &c) -- but I didn't submit it.

The issue is that this box is never loading:


The 500 error still occurs for me, too. But, at least I have a workaround for now \o/

(Are remote PRs supposed to 404 when attempting to go to a forked repo...?)

The issue is that this box is never loading:

That is likely related to the issue you've seen in your browser's console about failing to find a function. I'll need to check upstream if I can reproduce it and fix it.

Metadata Update from @pingou:
- Issue tagged with: dev

3 years ago

@cipherboy if you have the time/opportunity, could you see if this still happens to you?

Metadata Update from @pingou:
- Issue assigned to pingou

3 years ago

Metadata Update from @pingou:
- Issue priority set to: Waiting on Reporter (was: Waiting on Assignee)

3 years ago

@pingou \o/ joy! it works! Thanks!! :D

Metadata Update from @cipherboy:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

3 years ago

Login to comment on this ticket.

Boards 1
dev Status: Done
Attachments 1