newsflash on master [⇡?] ❯ git push Enumerating objects: 5, done. Counting objects: 100% (5/5), done. Delta compression using up to 8 threads Compressing objects: 100% (3/3), done. Writing objects: 100% (3/3), 1.19 KiB | 1.19 MiB/s, done. Total 3 (delta 2), reused 0 (delta 0), pack-reused 0 fedpkg build remote: Emitting a message to the fedora-messaging message bus. remote: Traceback (most recent call last): remote: File "/usr/share/git-core/post-receive-fedora-messaging", line 153, in <module> remote: commits = [_build_commit(rev) for rev in revs] remote: File "/usr/share/git-core/post-receive-fedora-messaging", line 153, in <listcomp> remote: commits = [_build_commit(rev) for rev in revs] remote: File "/usr/share/git-core/post-receive-fedora-messaging", line 123, in _build_commit remote: if instance(rev, str): remote: NameError: name 'instance' is not defined remote: Sending to redis to log activity and send commit notification emails remote: * Publishing information for 1 commits remote: - to fedora-message To ssh://pkgs.fedoraproject.org/rpms/newsflash b876bdc..8f9f57d master -> master
seems that hook should be using isinstance() instead, but I have no idea where to send patch.
isinstance()
cc @pingou
Thanks Igor!
The file is actually in ansible in roles/git/hooks/... I've fixed it on the server and in ansible so we should be good here.
Could you double-check?
Metadata Update from @pingou: - Issue assigned to pingou
I think it is fine now. Will reopen if happens again.
Metadata Update from @ignatenkobrain: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.