#8993 OpenID login is broken (Bodhi, fedora-magazine, community blog, pagure.io)
Closed: Fixed 3 years ago by cverna. Opened 3 years ago by cverna.

Describe what you would like us to do:


Trying to login to bodhi currently returns a 500 error.

the backtrace on the pods

[Tue Jun 09 06:39:07.870625 2020] [wsgi:error] [pid 17:tid 140102621714176] [client 10.131.0.1:56670] 2020-06-09 06:39:07,869 ERROR [bodhi.server][Dummy-1] Error caught.  Handling HTML response.
[Tue Jun 09 06:39:07.870658 2020] [wsgi:error] [pid 17:tid 140102621714176] [client 10.131.0.1:56670] Traceback (most recent call last):
[Tue Jun 09 06:39:07.870662 2020] [wsgi:error] [pid 17:tid 140102621714176] [client 10.131.0.1:56670]   File "/usr/lib/python3.8/site-packages/pyramid/tweens.py", line 41, in excview_tween
[Tue Jun 09 06:39:07.870676 2020] [wsgi:error] [pid 17:tid 140102621714176] [client 10.131.0.1:56670]     response = handler(request)
[Tue Jun 09 06:39:07.870678 2020] [wsgi:error] [pid 17:tid 140102621714176] [client 10.131.0.1:56670]   File "/usr/lib/python3.8/site-packages/pyramid/router.py", line 147, in handle_request
[Tue Jun 09 06:39:07.870681 2020] [wsgi:error] [pid 17:tid 140102621714176] [client 10.131.0.1:56670]     response = _call_view(
[Tue Jun 09 06:39:07.870683 2020] [wsgi:error] [pid 17:tid 140102621714176] [client 10.131.0.1:56670]   File "/usr/lib/python3.8/site-packages/pyramid/view.py", line 667, in _call_view
[Tue Jun 09 06:39:07.870685 2020] [wsgi:error] [pid 17:tid 140102621714176] [client 10.131.0.1:56670]     response = view_callable(context, request)
[Tue Jun 09 06:39:07.870687 2020] [wsgi:error] [pid 17:tid 140102621714176] [client 10.131.0.1:56670]   File "/usr/lib/python3.8/site-packages/pyramid/viewderivers.py", line 426, in viewresult_to_response
[Tue Jun 09 06:39:07.870690 2020] [wsgi:error] [pid 17:tid 140102621714176] [client 10.131.0.1:56670]     raise ValueError(msg % (view_description(view), result))
[Tue Jun 09 06:39:07.870692 2020] [wsgi:error] [pid 17:tid 140102621714176] [client 10.131.0.1:56670] ValueError: Could not convert return value of the view callable function pyramid_fas_openid.view.verify_openid into a response object. The value returned was None. You may have forgotten to return a value from the view callable.

When do you need this to be done by? (YYYY/MM/DD)



It seems to be related to all the OpenID client since the fedora magazine and community blog login is also broken.

Metadata Update from @cverna:
- Assignee reset

3 years ago

OK this is now fixed, we needed to allow the OpenShift router to use a wildcard certificate, I have done this by running the following command on os-master01.

$ oc -n default set env dc/router ROUTER_ALLOW_WILDCARD_ROUTES=true

We need to had that command to the ipsilon playbook, so that we make sure this env variable is in place next time we deploy that service.

Is this only for ipsilon or is it going to be a generic openshift-app setting?

@mobrien general Openshift setting.
It's a setting on the global routers

@cverna this should go into the openshift playbooks, as it's not ipsilon-specific, and is a global change.

This may be in the wrong place but it seemed some way logical to ensure the env var was set before the build commenced.

https://pagure.io/fedora-infra/ansible/pull-request/117#

Metadata Update from @cverna:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

3 years ago

Login to comment on this ticket.

Metadata