This is a follow-up to #8157.
Apparently, ansible-review doesn't catch syntax errors like misindentation or unbalanced quotes. Run ansible-playbook --check ... additionally to catch these.
ansible-playbook --check ...
See fedora-infra/ansible#54 and fedora-infra/ansible#60 regarding where to put changes to our Zuul jobs.
@nphilipp Is the work done, can we close the ticket?
@mohanboddu No, it's not :grinning:. This ticket is for what ansible-review (for some reason surprising reason) doesn't do, i.e. syntax check. See the convo on the mailing list.
Metadata Update from @nphilipp: - Issue assigned to nphilipp
Metadata Update from @smooge: - Issue priority set to: Waiting on Assignee (was: Needs Review) - Issue tagged with: groomed, low-trouble, medium-gain
So, how can we fix this? Do we have any plan or idea here? Or should we perhaps meet up and discuss it?
Not clear what we are to do about this? This sounds like dev work to add items to ansible-playbook
Metadata Update from @smooge: - Issue tagged with: dev
Note that currently the Zuul jobs for the fedora-infra/ansible repo are not being kicked off. This is tracked in the following ticket that might be worth fixing first before doing this one (or doing both at once :) )
https://pagure.io/fedora-infrastructure/issue/9524
https://pagure.io/fedora-infrastructure/issue/9524 is now fixed, FWIW
This one might be invalid now too, btw:
I did a test with mismatched quotes and indentation issues, and the zuul build fails:
https://pagure.io/fedora-infra/ansible/pull-request/332#comment-138685
Cool, but I think we were hoping for output like ansible-playbook --syntax-check? that gives line number and some more info... I am not sure how to get zuul to run that test too tho. ;(
I guess for now that should be good enough?
Thanks @ryanlerch
Metadata Update from @kevin: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.