See for example:
https://pagure.io/releng/fedora-scm-requests/issue/19437
This is a fedpkg supported feature, we should make this available to folks who want to maintain tests this way. Note there are already multiple tests repos created before ....
@hhorak @psss @bookwar
So, I am not sure where the problem is here (but its likely not infrastructure):
I guess we can try and coordinate here and figure out who needs fixing. :)
Metadata Update from @kevin: - Issue priority set to: Waiting on Assignee (was: Needs Review)
I think we need to fix fedscmadmin:
{ "action": "new_repo", "namespace": "tests", "repo": "mariadb", "description": "Repository for MariaDB integration tests" }
The requests from fedpkg request-tests-repo ... looks like this ...
fedpkg request-tests-repo ...
Would be nice to get this fixed soon.
I gave a look here and I think there's a problem about what fedpkg request-tests-repo sends in its message and what fedscm-admin wants to see in the message it receives.
fedpkg request-tests-repo
fedscm-admin
About fedpkg, I see the missing branch key has been fixed a couple of months ago in https://pagure.io/fedpkg/c/37f8972 So it now sends https://pagure.io/fedpkg/blob/37f8972/f/fedpkg/cli.py#_834
fedpkg
branch
if ns == 'tests': # check if tests repository does not exist already assert_new_tests_repo(repo_name, get_dist_git_url(anongiturl)) ticket_body = { 'action': 'new_repo', 'branch': 'master', 'namespace': 'tests', 'repo': repo_name, 'description': description, }
On the other side, fedscm-admin processes the new_repo action with the prompt_for_new_repo() method https://pagure.io/fedscm-admin/blob/master/f/fedscm_admin/utils.py#_280 which requires these keys to be present in the message:
new_repo
prompt_for_new_repo()
required_keys = [ 'repo', 'branch', 'bug_id', 'action', 'namespace', 'sls', 'monitor']
So it requires the bug_id like a new package review ticket.
bug_id
The choices are three: add the bug_id key to fedpkg request-tests-repo (it should be required to open a ticket in Bugzilla to create such repository?); modify fedscm-admin to ignore the absence of bug_id if namespace is tests; modify both by adding a new action type specifically for creating tests repositories.
namespace
tests
action
As a side note I would like to raise your attention on https://pagure.io/fedscm-admin/blob/master/f/fedscm_admin/utils.py#_378 By a quick look it seems to me that the component that will be created on PDC will be named test instead of tests... not sure if it can be an issue.
test
@mattia thanks for looking. There is no bug for these requests and I believe that is ok. This is not a new package, solely a new tests repo people will use to share tests outside of dist-git. So I would opt for not requiring a bug_id.
Ah, seems there is already an upstream ticket for this:
https://pagure.io/fedscm-admin/issue/22
Lets close this one in favor of that one...
Metadata Update from @kevin: - Issue close_status updated to: Upstream - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.