#8683 Fedmsg sometimes inserts unhelpful / unrelated messages into #fedora-design
Closed: Fixed 3 years ago by kevin. Opened 4 years ago by duffy.

Here are some example messages that the fm-design bot inserts into the channel:

<fm-design> pagure.issue.comment.added -- labbott commented on ticket mentored-projects#74: "Fedora Badges Back-end Engineering" https://pagure.io/mentored-projects/issue/74#comment-627964
<fm-design> pagure.git.receive -- jibecfed pushed 1 commit to fedora-docs-l10n/minimization (master) https://pagure.io/fedora-docs-l10n/minimization/tree/master
Tree - fedora-docs-l10n/minimization - Pagure.io
fedora-docs-l10n / minimization Clone Source Code GIT Source Issues 0
pagure.git.receive -- jibecfed pushed 1 commit to fedora-docs-l10n/badges (master) https://pagure.io/fedora-docs-l10n/badges/tree/master

I had thought maybe there was a panel to customize what messages we get sent as a team like we can customize what fedora-notif PMs you as an individual with a fas account, but that appears not to be the case. Smooge took a look this weekend and said there are ansible rules / regexps that control what messages go to what channels, and these kind of unhelpful messages are probably getting sent to #fedora-design bc they have the keyword 'badges' in them.

I'm really trying to clean up and streamline the design team infrastructure and make the channel a more welcoming place, so it would be very nice to put the irrelevant notification messages on hold.


Describe what a you would like us to do:

Would it be possible to revisit the regexp for the bot that sends notifications to #fedora-design and remove the rule that sends anything that has the word 'badges' in it to the channel? I think tickets put on the badges queue specifically are great, but anything across all of fedora that relates to badges seems to generate a lot of unhelpful noise.

Even better, if you could point me to the rules and I could try to review and assess whether or not they're all working for us right now or not, I would greatly appreciate that.


When do you need this to be done by? (YYYY/MM/DD)

There is no urgency to this at all, thank you for any time you have to help with this.



Metadata Update from @smooge:
- Issue priority set to: Waiting on Assignee (was: Needs Review)

4 years ago

Here's another one that came today that's problematic in another way -

<fm-design> irc.karma -- sayanchowdhury gave jflory7(251) a karma cookie in #fedora-badges. "jwf++" https://badges.fedoraproject.org/user/jflory7
Fedora Badges
About Explore Leaderboard Login User Info jflory7 Justin W. Flory Arrived on 2014-01-01. Ranked 7 out of 56039 ranked users (top 0.02%).

Informing one IRC channel of activity in another IRC channel seems a bit off. Let the client handle that. If I wanted to monitor another channel, I'd join it. (I think this one came through bc of the 'badges' mention)

The filtering is just looking for regex in a stream of data using what is set in roles/fedmsg/irc/templates/ircbot.py

         # Hook up the design-team with badges messages                                                                                                                                        
        dict(
            network='chat.freenode.net',
            port=6667,
            make_pretty=True,
            make_terse=True,

            {% if env == 'staging' %}
            nickname='fm-stg-design',
            {% else %}
            nickname='fm-design',
            {% endif %}
            channel='#fedora-design',
            filters=dict(
                body=['^((?!(fedora-badges|design-team|fedoradesign)).)*$'],
            ),
        ),

The ones you are seeing are just hitting those somewhere in the body. Looking at other examples, it can be filtered down further to just look at pagure or some other fedmsg topic.

                topic=[
                    '^((?!(pagure)).)*$',
                ],

Metadata Update from @cverna:
- Issue tagged with: help wanted

4 years ago

@duffy would filtering down to just look at pagure or some other specific topic work for you?

@pingou cc @jflory7

looking at the topics on https://fedora-fedmsg.readthedocs.io/en/latest/

I think what would be ideal is:

  • all pagure topics, related to the pagure.io/design only (no badges)
  • all mailman topics, related to design-team@lists.fedoraproject.org only (no badge mailing lists, docs, i18n, etc)
  • all meetbot topics for #fedora-design
  • all nuancier topics
  • all fedoracal topics for calendar_name 'design'
  • if possible all github topics for fedora-design
  • if possible, all wiki topics for fedoraproject.org/wiki/Design

Hi, to follow up, I think I pushed a fix, but this ticket should remain open for a few more days since I did not test out my changes to see what ends up getting captured by the new filter.

Here are my two commits:

https://pagure.io/fedora-infra/ansible/c/cebda1a06163b584f4f12111e8fe401dee89cd8b?branch=master

https://pagure.io/fedora-infra/ansible/c/e4cc960f771d947e820dbfd263ce14bbc5cca4bb?branch=master

@cverna @smooge @kevin @siddharthvipul1 Hi folks, this ticket should just need a playbook run but I'm actually not sure how to push the ^above commits into production. Could someone else please assist?

Hi @jflory7! This repo is "production", see Kevin's announcement on the list. If you want your changes to be reviewed, or be subjected to the modicum of CI tests we have in place before they're effective in future playbook runs, you can submit a PR here.

@nphilipp Thanks, I missed that. Will remember for next time.

I think this ticket is good to close. The #fedora-design channel is much more quiet now :smile:

Metadata Update from @kevin:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

3 years ago

Login to comment on this ticket.

Metadata