#8427 Cannot merge src.fp.o pull requests: waiting....
Closed: Fixed 4 years ago by churchyard. Opened 4 years ago by churchyard.

I have the following two PRs:

https://src.fedoraproject.org/rpms/python39/pull-request/2
https://src.fedoraproject.org/rpms/python39/pull-request/3

After clicking on merge, it just waits with: This is taking longer than usual... Sorry for that.

https://src.fedoraproject.org/wait/527f47c3-1325-4ba0-844e-52efa20ea8bd
https://src.fedoraproject.org/wait/594d3583-37fb-45fa-acc2-8b7c03d56076

The first merge actually pushed all the commits to the f31 branch and now it lists zero commits in the pull request.
The second did not do that.

Is some worker busted?


I'm looking at the logs on the server and I'm not seeing any traceback the PR 2 seems to have worked fine and was just large and slow.
PR 3 on the other hand is more surprising, the merge worked but the PR wasn't closed in the DB :(

Another thing that surprise me is that src.fp.o seems to only have one worker while pagure.io has the _fast, _medium and _slow workers but looking at ansible it seems src.fp.o never had them so this surprises me but may be fine in fact.

Both PRs are good now.

What is surprising here to me is that the operation is not atomic. I.e. it seems that there are several stages when in between the stages the PR might have been marked as "being merged". However that is out of scope here.

If you have made it so manually in the DB and would like a pagure upstream issue, let me know.

Thanks for looking into this. I will just try to be more patient when merging 600+ commits PRs.

Metadata Update from @churchyard:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

4 years ago

If you have made it so manually in the DB

I actually did not, so that means it fixed itself and was just slow :(

Login to comment on this ticket.

Metadata