#8161 F31 updates set for 7 days in testing
Closed: Duplicate a month ago by churchyard. Opened 2 months ago by churchyard.

https://fedoraproject.org/wiki/Updates_Policy

All non critical path updates MUST either reach the prescribed karma level for that update, OR spend at least 3 days in updates-testing before being allowed to move to stable.

Yet all my f31 updates are set for 7 days, not 3:

  • in testing 2 days ago, days to stable 6
  • in testing 2 days ago, days to stable 5
  • ...

well, technically you are right, but... we are in freeze for beta, so we could set it back to 3 and change it to 7 only after beta, but only FBR and blocker updates are allowed through the freeze, so I am not sure it matters.

If there's some reason we can switch it to 3 now and back to 7 after beta if you want, but seems like a waste of effort.

I completely agree it should have been this way for pre-freeze beta. :(

Metadata Update from @kevin:
- Issue priority set to: Waiting on Reporter (was: Needs Review)

2 months ago

I don't really mind if my updates with freeze exception and without karma move into stable in 7 or 3 days. I've only opened this because it felt... broken. I think this already happened with previous release(s), haven't it?

If it would be easier to simplify the policy, we can also do that.

This should be automatically set by ansible. I am not sure yet why it wasn't... I need to fix a issue with the basessh role before I can run the bodhi playbook with --check --diff to see why it's not setting this right.

Sent a FBR to the list about that one.

Fixed now. Was a typo/mistake in a variable name. ;(

Metadata Update from @kevin:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

a month ago

It seems like after this change Autopush (time) is not getting triggered, and Bodhi is not submitting anything to stable (even though it wouldn't get pushed right now.)

Submitting to stable != pushing to stable.

They used to be submitted automatically, but not pushed due to the freeze.

You are correct. I've just noticed that I have to submit the f31 updates to stable manually.

@abompard @cverna @bowlofeggs

Perhaps the backend needs restarted? What process handles the autopush?

@kevin A cron job in backend01 was responsible for doing the messaging about when packagers could push to stable the last time i worked on Bodhi, but I haven't worked on Bodhi since it did pushing based on time. iirc, and it's been a looooong time, the same script does the time based request for stabilization, and that would be /usr/bin/bodhi-approve-testing.

It should use the settings from the production.ini on backend01.

Of course, it's possible things have changed and my info might be outdated.

Metadata Update from @cverna:
- Issue status updated to: Open (was: Closed)

a month ago

Metadata Update from @cverna:
- Issue assigned to cverna

a month ago

Ok so this is a bit confusing :smile:

Bodhi has 2 concepts :

  • mandatory_time_in_testing : which are the mandatory number of days an update needs to spend in testing. ( this is defined by the policy)
  • stable_days : This is the number of days the person creating the update wants his update to spend in testing before being automatically pushed to stable.

stable_days can be set when creating or editing the update, but it defaults to 7 days and it cannot be smaller than the mandatory_days_in_testing.

So you could edit your updates and set the stable days to 3 then they will start getting submitted to stable.

On the Bodhi side we could try to adapt the default value based on the mandatory_days_of_testing.

OK, but for example this update has (according to the sidebar) been in testing for 11 days, and it's on the default settings (so 7 days), so it should have been automatically submitted by now.

OK, but for example this update has (according to the sidebar) been in testing for 11 days, and it's on the default settings (so 7 days), so it should have been automatically submitted by now.

Ok this is bug, bodhi ignores the update because it already has the comment that let the packager now that he can submit the update to stable.

I have created 2 upstream issue base on the comment on this ticket

https://github.com/fedora-infra/bodhi/issues/3506
https://github.com/fedora-infra/bodhi/issues/3507

I think we can close this ticket and track the upstream issue.

Metadata Update from @churchyard:
- Issue close_status updated to: Duplicate
- Issue status updated to: Closed (was: Open)

a month ago

Login to comment on this ticket.

Metadata