#8113 failures to create git branches
Closed: Upstream 4 years ago by pingou. Opened 4 years ago by loveshack.

A fair fraction of my branch requests for epel8 have failed to create the branch in git, getting closed with "The branch in PDC already exists". An example is https://pagure.io/releng/fedora-scm-requests/issue/15420


Sounds like pdc is getting updated, but the branch isn't being made on pkgs02.

@limb have you noticed any errors on branch create?

Could we perhaps have the tool check for the branch also and not just PDC before rejecting the request at least?

ie, if PDC has it, but no branch, process the branch creation?

Metadata Update from @kevin:
- Issue priority set to: Waiting on Assignee (was: Needs Review)

4 years ago

Yes, sometimes there are 400s, retry errors, but I've not been able to recreate it reliably.

Some repositories have enabled the hook preventing git branch creation. In this situation, the user needs to turn off this hook, create and push the branch manually (ie using: git checkout -b epel8 && git push -u origin epel8) and turn the hook back on.

So, can we have the fedscm-admin tool check that and unset it, make branch, set it again? or override it somehow?

So, can we have the fedscm-admin tool check that and unset it, make branch, set it again? or override it somehow?

We can't quite override this since it's acting at the git level.
There are two ways we could improve this:

  • Expand the error message to inform the user that they can create the branch themselves but that they potentially need to turn off this git hook first
  • Expand pagure's API to allow enabling/disabling git hook status so fedscm-admin can do it

Note: I don't think there is anything we should track here.

There is potentially two tickets for fedscm-admin and one for pagure but not much infra can do :)

ok, can you file those and we can close this? Or you want me to?

-fedscm-admin request at: https://pagure.io/fedscm-admin/issue/19
- pagure request at: https://pagure.io/pagure/issue/4605

Let's close this one :)

Metadata Update from @pingou:
- Issue close_status updated to: Upstream
- Issue status updated to: Closed (was: Open)

4 years ago

Login to comment on this ticket.

Metadata