#7893 Fix broken URL in Mailman footer and set up URL redirect for URL in archives
Closed: Fixed by jflory7. Opened by jflory7.

Hi, I was rerouted from Fedora-Council/tickets#256. Currently, the Code of Conduct URL in the global Mailman footer used on all Fedora lists is a 404 error:

https://getfedora.org/code-of-conduct.html

It should be updated to this URL:

https://docs.fedoraproject.org/en-US/project/code-of-conduct/

@till also suggested to set up a URL redirect so anyone that hits the URL from messages in the archive will be redirected to the right place.

Thanks!


fixed, ansible 4547a73ef89a6f7a909a1530d79760e978835825

Metadata Update from @codeblock:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

Thanks @codeblock for updating the footer! :raised_hands:

I noticed the broken URL does not redirect. Is it possible to create this to benefit messages already in the lists archive? It would be a helpful change since it was probably used in other places outside of the mailing lists too.

Metadata Update from @jflory7:
- Issue status updated to: Open (was: Closed)

Heh, the multitude of different locations for the code of conduct came up a year or so ago when we were adding the mailman footer. (https://pagure.io/fedora-infrastructure/issue/6794#comment-505704)

As far as a redirect for the existing getfedora.org/code-of-conduct.html link, I think the attached would do the trick. If the httpd/redirect task supported RedirectMatch we could simplify this, but the template looks a bit too simplistic for that.

If the patch looks good, I can push it directly to save someone the effort of saving and applying with git am.

0001-proxy-redirects-redirect-getfedora.org-code-of-condu.patch

@tmz Thanks for the patch! It looks like the target URLs are incorrect. The current home for the CoC is here:

https://docs.fedoraproject.org/en-US/project/code-of-conduct/

It may help to also update the previous entries for other redirects too.

My, that code-of-conduct URL is slippery. ;)

I updated my local repo to adjust the existing redirect destinations in an initial commit, then updated the commit from my attached patch. I'll attach both here as well, in case I'm not around if/when these get an OK.

0001-proxy-redirects-update-code-of-conduct-URL.patch
0002-proxy-redirects-redirect-getfedora.org-code-of-condu.patch

Super, thanks @tmz! Looks good to me. :grinning:

Thanks @jflory7. Those changes are now in ansible as:

b7edc70ea ("proxy-redirects: update code-of-conduct URL", 2019-06-11)
aa8a60065 ("proxy-redirects: redirect getfedora.org/code-of-conduct.html to docs", 2019-06-11)

Now we just need someone to run the requisite ansible play[s].

The redirects look to be in place to me. :smile: I'm going to close this as Fixed. :clapper:

Thanks @codeblock and @tmz!

Metadata Update from @jflory7:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

Is it expected that the mailman footer has not yet changed? New messages to the devel and users lists still have the old CoC. With the redirects in place, that's not really a problem.

I'm not sure if the requisite playbook has just not been run yet or if there's some other reason the footer template isn't doing what it should despite the change in 4547a73ef ("mailman: fix footer link for CoC", 2019-06-11).

The playbook had not been run. It has now.

Metadata