#7626 Traceback on dist-git push over https://
Closed: Fixed 6 months ago by pingou. Opened a year ago by kanarip.

  • Describe what you need us to do:

Address traceback in post-receive-fedmsg hook

  • When do you need this? (YYYY/MM/DD)


  • When is this no longer needed or useful? (YYYY/MM/DD)


  • If we cannot complete your request, what is the impact?

Nothing worth getting our panties in a twist over.


[vanmeeuwen@dws06 python-multilib (master u+1)]$ git push origin master 
Enumerating objects: 5, done.
Counting objects: 100% (5/5), done.
Delta compression using up to 8 threads
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 419 bytes | 419.00 KiB/s, done.
Total 3 (delta 1), reused 0 (delta 0)
remote: Emitting a message to the fedmsg bus.
remote: Traceback (most recent call last):
remote:   File "/usr/share/git-core/post-receive-fedmsg", line 141, in <module>
remote:     commits = map(_build_commit, revs)
remote:   File "/usr/share/git-core/post-receive-fedmsg", line 138, in _build_commit
remote:     agent=getlogin(),
remote:   File "/usr/share/git-core/post-receive-fedmsg", line 91, in getlogin
remote:     return os.environ['USER']
remote:   File "/usr/lib64/python2.7/UserDict.py", line 23, in __getitem__
remote:     raise KeyError(key)
remote: KeyError: 'USER'
remote: Sending to redis to log activity and send commit notification emails
remote: * Publishing information for 1 commits
remote:   - to fedmsg
To https://src.fedoraproject.org/rpms/python-multilib.git
   6bfa01e..a0c985e  master -> master
[vanmeeuwen@dws06 python-multilib (master u=)]$ 

It looks like the mechanism we have in place for https based push isn't setting up the USER environment variable.
However, I'm not clear where this should be fixed :(

Metadata Update from @mizdebsk:
- Issue priority set to: Waiting on Assignee (was: Needs Review)
- Issue tagged with: src.fp.o

a year ago

So, after talking with @puiterwijk we want to just move to the new https handling in pagure next week and drop gitolite. That should fix this issue and get us ready to move projects to repospanner.

Metadata Update from @kevin:
- Issue assigned to puiterwijk

a year ago

pagure has been moved away from gitolite and thus this issue should be fixed.

I'm going to close this ticket as such, please re-open it or open a new one if the issue happens again :)

Thanks for your report!

Metadata Update from @pingou:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

6 months ago

Login to comment on this ticket.