#7483 Pushing a dist-git commit with non-ASCII characters shows a traceback: UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 7: ordinal not in range(128)
Closed: Fixed 5 years ago by pingou. Opened 5 years ago by ppisar.

Pushing to rpms/perl-File-Temp dist-git repository shows a non-fatal Python traceback:

$ git push && fedpkg build
Total 0 (delta 0), reused 0 (delta 0)
remote: Emitting a message to the fedmsg bus.
remote: * Publishing information for 1 commits
remote: Traceback (most recent call last):
remote:   File "/usr/lib/python2.7/site-packages/pagure/hooks/__init__.py", line 394, in run_project_hooks
remote:     changes=changes,
remote:   File "/usr/lib/python2.7/site-packages/pagure/hooks/__init__.py", line 111, in runhook
remote:     changes=changes,
remote:   File "/usr/lib/python2.7/site-packages/pagure/hooks/default.py", line 279, in post_receive
remote:     session, project, repodir, username, refname, commits, forced
remote:   File "/usr/lib/python2.7/site-packages/pagure/hooks/default.py", line 72, in send_notifications
remote:     name = pagure.lib.git.get_author(rev, repodir)
remote:   File "/usr/lib/python2.7/site-packages/pagure/lib/git.py", line 1317, in get_author
remote:     ["log", "-1", '--pretty=format:"%an"', commit], abspath
remote:   File "/usr/lib/python2.7/site-packages/pagure/lib/git.py", line 1261, in read_git_lines
remote:     args, abspath, keepends=keepends, **kw
remote:   File "/usr/lib/python2.7/site-packages/pagure/lib/git.py", line 1246, in read_git_output
remote:     **kw
remote:   File "/usr/lib/python2.7/site-packages/pagure/lib/git.py", line 1227, in read_output
remote:     out = out.rstrip("\n\r")
remote: UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 7: ordinal not in range(128)
remote: Sending to redis to send commit notification emails
To ssh://pkgs.fedoraproject.org/rpms/perl-File-Temp
   283f036..b11ec92  f29 -> f29

I noticed this behavior on 2019-01-07.


Metadata Update from @mizdebsk:
- Issue priority set to: Waiting on Assignee (was: Needs Review)
- Issue tagged with: src.fp.o

5 years ago

I believe this has been fixed since, please let us know if that is not the case :)

Metadata Update from @pingou:
- Issue priority set to: Waiting on Reporter (was: Waiting on Assignee)

5 years ago

Metadata Update from @pingou:
- Issue assigned to pingou

5 years ago

I've received confirmation on IRC from @lsedlar that this issue is fixed :)

Metadata Update from @pingou:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

5 years ago

Login to comment on this ticket.

Metadata