#7368 Greenwave policy for container updates
Closed: Fixed 3 years ago Opened 3 years ago by cverna.

  • Describe what you need us to do:

We have started to use container updates in bodhi, but currently the updates are not pushed to stable because "'Required tests did not pass on this update".

We need a policy in greenwave to allow maintainer to opt-in for the gating and allow updates to be pushed to stable by default.

  • When do you need this? (YYYY/MM/DD)

  • When is this no longer needed or useful? (YYYY/MM/DD)

  • If we cannot complete your request, what is the impact?


The error message from greenwave is:

{
  "message": "Cannot find any applicable policies for koji_build subjects at gating point bodhi_update_push_stable in fedora-29-containers"
}

Source: the call made by bodhi at: https://bodhi.fedoraproject.org/updates/FEDORA-CONTAINER-2018-2ea129b488

Metadata Update from @bowlofeggs:
- Issue priority set to: Waiting on Assignee (was: Needs Review)

3 years ago

I believe this should fix it:

diff --git a/ roles/openshift-apps/greenwave/templates/configmap.yml b/ roles/openshift-apps/greenwave/templates/configmap.yml
index bbd14db5f..a464951d7 100644
--- a/ roles/openshift-apps/greenwave/templates/configmap.yml   
+++ b/ roles/openshift-apps/greenwave/templates/configmap.yml   
@@ -140,7 +140,9 @@ data:
     --- !Policy
     id: "no_requirements_testing"
     product_versions:
+      - fedora-29-containers
       - fedora-29-modular
+      - fedora-28-containers
       - fedora-28-modular
       - fedora-epel-7
       - fedora-epel-6
@@ -152,7 +154,9 @@ data:
     --- !Policy
     id: "no_requirements_for_stable"
     product_versions:
+      - fedora-29-containers
       - fedora-29-modular
+      - fedora-28-containers
       - fedora-28-modular
       - fedora-epel-7
       - fedora-epel-6

Metadata Update from @pingou:
- Issue priority set to: Needs Review (was: Waiting on Assignee)

3 years ago

Metadata Update from @pingou:
- Issue priority set to: Waiting on Assignee (was: Needs Review)

3 years ago

That looks right to me. I'll commit and push it out now.

Metadata Update from @ralph:
- Issue assigned to ralph

3 years ago

Looks fixed to me. Try to push it again?

This is working, thanks all

Metadata Update from @cverna:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

3 years ago

Login to comment on this ticket.

Metadata