Issue #7229: dist-git doesn't allow branches with unicode characters - fedora-infrastructure

fedora-infrastructure

#7229 dist-git doesn't allow branches with unicode characters

Closed: Fixed 5 years ago by pingou. Opened 5 years ago by ignatenkobrain.

Describe what you need us to do:

⋊> /v/t/f/python-hypothesis on koňský  git push brain koňský -u                                                                     18:37:00
Enumerating objects: 9, done.
Counting objects: 100% (9/9), done.
Delta compression using up to 8 threads
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 1.39 KiB | 1.39 MiB/s, done.
Total 5 (delta 2), reused 0 (delta 0)
remote: FATAL: invalid characters in ref or filename: 'refs/heads/koňský'
remote: 
remote: error: hook declined to update refs/heads/koňský
To ssh://pkgs.fedoraproject.org/forks/ignatenkobrain/rpms/python-hypothesis
 ! [remote rejected] koňský -> koňský (hook declined)
error: failed to push some refs to 'ssh://ignatenkobrain@pkgs.fedoraproject.org/forks/ignatenkobrain/rpms/python-hypothesis'

This works just perfectly in GitHub.

When do you need this? (YYYY/MM/DD)

Anytime.

When is this no longer needed or useful? (YYYY/MM/DD)

When unicode dies. I don't have dates, though.

If we cannot complete your request, what is the impact?

People are unable to use unicode characters in branch names.

puiterwijk commented 5 years ago

This is a limitation of gitolite, and will be fixed when we move to repoSpanner.

Metadata Update from @puiterwijk:
- Issue assigned to puiterwijk

5 years ago

Metadata Update from @kevin:
- Issue priority set to: Waiting on External (was: Needs Review)

5 years ago

Metadata Update from @kevin:
- Issue tagged with: repoSpanner

5 years ago

kevin commented 5 years ago

This is not quite working in stg yet... it seems to now be a hook issue:

➜  apg git:(⛄) git push --set-upstream origin ⛄
Enumerating objects: 8, done.
Counting objects: 100% (8/8), done.
Delta compression using up to 8 threads
Compressing objects: 100% (6/6), done.
Writing objects: 100% (6/6), 586 bytes | 293.00 KiB/s, done.
Total 6 (delta 4), reused 0 (delta 0)
remote: Traceback (most recent call last):
remote:   File "hooks/pre-receive", line 36, in <module>
remote:     run_hook_file(hooktype)
remote:   File "/usr/lib/python2.7/site-packages/pagure/hooks/__init__.py", line 500, in run_hook_file
remote:     changes = extract_changes(from_stdin=hooktype != "update")
remote:   File "/usr/lib/python2.7/site-packages/pagure/hooks/__init__.py", line 483, in extract_changes
remote:     (oldrev, newrev, refname) = line.strip().split(" ", 2)
remote: UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 93: ordinal not in range(128)
To ssh://pkgs.stg.fedoraproject.org/forks/kevin/rpms/apg.git
 ! [remote rejected] ⛄ -> ⛄ (pre-receive hook declined)
error: failed to push some refs to 'ssh://kevin@pkgs.stg.fedoraproject.org/forks/kevin/rpms/apg.git'
➜  apg git:(⛄)

@pingou I guess this is in pagure. Want a ticket there? or keep this to track it?