• If we cannot complete your request, what is the impact?
  We will be unable to respond to SAR requests with badges info.

If someone doesn't beat me to it, I'll likely poke at this tomorrow.

Do note that this impacted your username but didn't for me, so the above
statement might be only partly true.

Random question: the doc about writing SAR script didn't specify how the scripts
should behave if say, an username is required but not provided. What is the
expected behavior then? Fail in silence? Return error code 1? Return error
message?

@pingou The SAR playbook should always provide both username and e-mail address since the documented SOP has the admin provide both[0]. That said, if it does not provide the data the script needs to succeed the script should fail with a non-0 exit code.

Of course, this doesn't mean that each script needs to provide both, but we do need to always provide both to the group of scripts, since some data is not tied to FAS accounts.

Of course, this doesn't mean that each script needs to provide both, but we do need to always provide both to the group of scripts, since some data is not tied to FAS accounts.

Mailman requires an email address but not necessarily an username, so we could
have requests with only an email address and no FAS account.

Pierre

Mailman requires an email address but not necessarily an username, so we could
have requests with only an email address and no FAS account.

Precisely - so a script should only fail if it needs an input that isn't provided - no sense in failing due to missing input that isn't used ☺

Also, I made a typo above:

Of course, this doesn't mean that each script needs to provide both

s/provide/use/

Fixed in https://infrastructure.fedoraproject.org/cgit/ansible.git/commit/?id=49a81fc

I'm seeing other errors, I'll fix them as well