#6928 fedpkg retire not updating pdc properly
Closed 5 years ago Opened 5 years ago by mohanboddu.

  • Describe what you need us to do:
    When someone retire a package there is fedmsg listener that updates pdc with appropriate values and I think its not working properly.

  • When do you need this? (YYYY/MM/DD)
    ASAP

  • If we cannot complete your request, what is the impact?
    Sometimes we might ship a package that is actually retired since there is no way of knowing whether it got blocked in koji or not unless someone reports it. As there is releng script that runs during nightly composes to query pdc and gets the retired packages and blocks them in koji. If pdc is not updated then those packages will never get blocked in koji.

Couple of tickets that I fixed manually:
https://pagure.io/releng/issue/7436
https://pagure.io/releng/issue/7420


@ralph can you see anything wrong with the listener? Its on pdc-backend02 I am pretty sure...

Metadata Update from @kevin:
- Issue priority set to: Waiting on Assignee (was: Needs Review)

5 years ago

Metadata Update from @ralph:
- Issue assigned to ralph

5 years ago

Let's consider this one: https://pagure.io/releng/issue/7436

Looking in the pdc-updater logs, I see this:

Apr 12 21:04:56 pdc-backend02.phx2.fedoraproject.org fedmsg-hub[9709]: [2018-04-12 21:04:56][pdcupdater.utils    INFO] RetireComponentHandler handling 2018-d945d5ee-e81f-4789-868a-b4fbb7985cd7 org.fedoraproject.prod.git.receive
Apr 12 21:04:56 pdc-backend02.phx2.fedoraproject.org fedmsg-hub[9709]: [2018-04-12 21:04:56][pdcupdater.handlers.retirement    INFO] Checking for file: https://src.fedoraproject.org/rpms/qupzilla/blob/{u'name': u'f28', u'slas': [{u'eol': u'2019-08-08', u'id': 729458, u'sla': u'bug_fixes'}, {u'eol': u'2019-08-08', u'id': 729457, u'sla': u'security_fixes'}], u'critical_path': False, u'global_component': u'qupzilla', u'active': True, u'type': u'rpm', u'id': 365540}/f/dead.pa
Apr 12 21:04:56 pdc-backend02.phx2.fedoraproject.org fedmsg-hub[9709]: [2018-04-12 21:04:56][pdcupdater.handlers.retirement    INFO] Seems not to actually be retired, possibly merge
Apr 12 21:05:24 pdc-backend02.phx2.fedoraproject.org fedmsg-hub[9709]: [2018-04-12 21:05:24][pdcupdater.utils    INFO] RetireComponentHandler handling 2018-a6e9bfc4-fec9-4e1b-a72d-457bd38e245d org.fedoraproject.prod.git.receive
Apr 12 21:05:24 pdc-backend02.phx2.fedoraproject.org fedmsg-hub[9709]: [2018-04-12 21:05:24][pdcupdater.handlers.retirement    INFO] Checking for file: https://src.fedoraproject.org/rpms/qupzilla/blob/{u'name': u'master', u'slas': [{u'eol': u'2222-01-01', u'id': 521536, u'sla': u'rawhide'}], u'critical_path': False, u'global_component': u'qupzilla', u'active': True, u'type': u'rpm', u'id': 260600}/f/dead.package

... which definitely looks like a bug. See that dict in the url? Not right.

Cooking pdc-updater-0.9.2 which includes that fix.

OK, pdc-updater-0.9.2-1.el7 should be in epel7-infra-stg now.. but, I want to check with @mprahl tomorrow first to see if the koji_tag length change that @qwan contributed to pdc-updater is going to interfere with any deployments Matt has planned.

There are actually a couple releases that we haven't deployed yet, so this 0.9.2 delivers more than one fix / new feature.

@ralph go for the update. I actually forgot that this needed to be deployed to have consistency with the new Koji tag format in MBS. Let's talk on IRC about fixing that.

OK. I'm rolling it out asap.

It's in prod. @mohanboddu, can you let us know if you see issues in the future?

Metadata Update from @ralph:
- Issue status updated to: Closed (was: Open)

5 years ago

Login to comment on this ticket.

Metadata