I pushed a commit to a src.fp.o repository that included a Closes: #1 to close a PR and I got a spew of database errors:
Closes: #1
remote: Emitting a message to the fedmsg bus. remote: * Publishing information for 1 commits remote: Sending to redis to log activity and send commit notification emails remote: Detailed log of new commits: remote: remote: remote: * commit 4b0f82fafb8b9f81574bec71ccee2ea26549d379 remote: * Author: Dan Callaghan <dcallagh@redhat.com> remote: * Date: Mon Apr 30 15:29:41 2018 +1000 remote: * remote: * Relax underscore dependency remote: * remote: * Closes #1 remote: 2018-04-30 18:12:55,152 [ERROR] __main__: (ProgrammingError) permission denied for relation pull_request_comments remote: 'INSERT INTO pull_request_comments (pull_request_uid, commit_id, user_id, filename, line, tree_id, comment, parent_id, notification, edited_on, editor_id, date_created) VALUES (%(pull_request_uid)s, %(commit_id)s, %(user_id)s, %(filename)s, %(line)s, %(tree_id)s, %(comment)s, %(parent_id)s, %(notification)s, %(edited_on)s, %(editor_id)s, %(date_created)s) RETURNING pull_request_comments.id' {'comment': u' Commit [4b0f82fa](https://src.fedoraproject.org/rpms/carto/c/4b0f82fa) fixes this pull-request', 'commit_id': None, 'user_id': 1551, 'pull_request_uid': u'5baa6608e28e44e5a2ab0a33047e7c91', 'notification': False, 'filename': None, 'parent_id': None, 'edited_on': None, 'tree_id': None, 'date_created': datetime.datetime(2018, 4, 30, 18, 12, 55, 146419), 'line': None, 'editor_id': None} remote: Traceback (most recent call last): remote: File "/usr/lib/python2.7/site-packages/pagure/hooks/files/pagure_hook.py", line 138, in fixes_relation remote: requestfolder=pagure.APP.config['REQUESTS_FOLDER'], remote: File "/usr/lib/python2.7/site-packages/pagure/lib/__init__.py", line 1210, in add_pull_request_comment remote: session.flush() remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/orm/scoping.py", line 150, in do remote: return getattr(self.registry(), name)(*args, **kwargs) remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/orm/session.py", line 1919, in flush remote: self._flush(objects) remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/orm/session.py", line 2037, in _flush remote: transaction.rollback(_capture_exception=True) remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/util/langhelpers.py", line 60, in __exit__ remote: compat.reraise(exc_type, exc_value, exc_tb) remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/orm/session.py", line 2001, in _flush remote: flush_context.execute() remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/orm/unitofwork.py", line 372, in execute remote: rec.execute(self) remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/orm/unitofwork.py", line 526, in execute remote: uow remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/orm/persistence.py", line 65, in save_obj remote: mapper, table, insert) remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/orm/persistence.py", line 602, in _emit_insert_statements remote: execute(statement, params) remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line 729, in execute remote: return meth(self, multiparams, params) remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/sql/elements.py", line 322, in _execute_on_connection remote: return connection._execute_clauseelement(self, multiparams, params) remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line 826, in _execute_clauseelement remote: compiled_sql, distilled_params remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line 958, in _execute_context remote: context) remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line 1159, in _handle_dbapi_exception remote: exc_info remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/util/compat.py", line 199, in raise_from_cause remote: reraise(type(exception), exception, tb=exc_tb) remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line 951, in _execute_context remote: context) remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/default.py", line 436, in do_execute remote: cursor.execute(statement, parameters) remote: ProgrammingError: (ProgrammingError) permission denied for relation pull_request_comments remote: 'INSERT INTO pull_request_comments (pull_request_uid, commit_id, user_id, filename, line, tree_id, comment, parent_id, notification, edited_on, editor_id, date_created) VALUES (%(pull_request_uid)s, %(commit_id)s, %(user_id)s, %(filename)s, %(line)s, %(tree_id)s, %(comment)s, %(parent_id)s, %(notification)s, %(edited_on)s, %(editor_id)s, %(date_created)s) RETURNING pull_request_comments.id' {'comment': u' Commit [4b0f82fa](https://src.fedoraproject.org/rpms/carto/c/4b0f82fa) fixes this pull-request', 'commit_id': None, 'user_id': 1551, 'pull_request_uid': u'5baa6608e28e44e5a2ab0a33047e7c91', 'notification': False, 'filename': None, 'parent_id': None, 'edited_on': None, 'tree_id': None, 'date_created': datetime.datetime(2018, 4, 30, 18, 12, 55, 146419), 'line': None, 'editor_id': None} remote: ERROR (ProgrammingError) permission denied for relation pull_requests remote: 'UPDATE pull_requests SET status=%(status)s, closed_by_id=%(closed_by_id)s, closed_at=%(closed_at)s, last_updated=%(last_updated)s WHERE pull_requests.id = %(pull_requests_id)s AND pull_requests.project_id = %(pull_requests_project_id)s' {'status': 'Merged', 'last_updated': datetime.datetime(2018, 4, 30, 18, 12, 55, 172538), 'closed_by_id': 1551, 'pull_requests_id': 1, 'pull_requests_project_id': 1561, 'closed_at': datetime.datetime(2018, 4, 30, 18, 12, 55, 167693)} remote: 2018-04-30 18:12:55,174 [ERROR] __main__: (ProgrammingError) permission denied for relation pull_requests remote: 'UPDATE pull_requests SET status=%(status)s, closed_by_id=%(closed_by_id)s, closed_at=%(closed_at)s, last_updated=%(last_updated)s WHERE pull_requests.id = %(pull_requests_id)s AND pull_requests.project_id = %(pull_requests_project_id)s' {'status': 'Merged', 'last_updated': datetime.datetime(2018, 4, 30, 18, 12, 55, 172538), 'closed_by_id': 1551, 'pull_requests_id': 1, 'pull_requests_project_id': 1561, 'closed_at': datetime.datetime(2018, 4, 30, 18, 12, 55, 167693)} remote: Traceback (most recent call last): remote: File "/usr/lib/python2.7/site-packages/pagure/hooks/files/pagure_hook.py", line 161, in fixes_relation remote: merged=True) remote: File "/usr/lib/python2.7/site-packages/pagure/lib/__init__.py", line 2760, in close_pull_request remote: session.flush() remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/orm/scoping.py", line 150, in do remote: return getattr(self.registry(), name)(*args, **kwargs) remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/orm/session.py", line 1919, in flush remote: self._flush(objects) remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/orm/session.py", line 2037, in _flush remote: transaction.rollback(_capture_exception=True) remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/util/langhelpers.py", line 60, in __exit__ remote: compat.reraise(exc_type, exc_value, exc_tb) remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/orm/session.py", line 2001, in _flush remote: flush_context.execute() remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/orm/unitofwork.py", line 372, in execute remote: rec.execute(self) remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/orm/unitofwork.py", line 526, in execute remote: uow remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/orm/persistence.py", line 60, in save_obj remote: mapper, table, update) remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/orm/persistence.py", line 518, in _emit_update_statements remote: execute(statement, params) remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line 729, in execute remote: return meth(self, multiparams, params) remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/sql/elements.py", line 322, in _execute_on_connection remote: return connection._execute_clauseelement(self, multiparams, params) remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line 826, in _execute_clauseelement remote: compiled_sql, distilled_params remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line 958, in _execute_context remote: context) remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line 1159, in _handle_dbapi_exception remote: exc_info remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/util/compat.py", line 199, in raise_from_cause remote: reraise(type(exception), exception, tb=exc_tb) remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/base.py", line 951, in _execute_context remote: context) remote: File "/usr/lib64/python2.7/site-packages/sqlalchemy/engine/default.py", line 436, in do_execute remote: cursor.execute(statement, parameters) remote: ProgrammingError: (ProgrammingError) permission denied for relation pull_requests remote: 'UPDATE pull_requests SET status=%(status)s, closed_by_id=%(closed_by_id)s, closed_at=%(closed_at)s, last_updated=%(last_updated)s WHERE pull_requests.id = %(pull_requests_id)s AND pull_requests.project_id = %(pull_requests_project_id)s' {'status': 'Merged', 'last_updated': datetime.datetime(2018, 4, 30, 18, 12, 55, 172538), 'closed_by_id': 1551, 'pull_requests_id': 1, 'pull_requests_project_id': 1561, 'closed_at': datetime.datetime(2018, 4, 30, 18, 12, 55, 167693)} remote: Emitting a message to the fedmsg bus. remote: * Publishing information for 1 commits
This issue is known upstream and may well be fixed in 4.0 (planned to deploy later this week).
Metadata Update from @kevin: - Issue assigned to pingou - Issue priority set to: Waiting on Assignee (was: Needs Review) - Issue tagged with: src.fp.o, unfreeze
This is tracked upstream at https://pagure.io/pagure/issue/2874
and turns out not to be fixed in 4.0, I'll see to get it fixed sooner rather than later :)
In the mean time, closing this ticket in favor of the upstream one.
Thanks for your report!
Metadata Update from @pingou: - Issue untagged with: unfreeze - Issue close_status updated to: Upstream - Issue priority set to: None (was: Waiting on Assignee)
Login to comment on this ticket.