#6872 Bodhi doesn't have a mailing list configured for "fedora_modular"
Closed: Fixed 2 years ago Opened 2 years ago by bowlofeggs.

  • Describe what you need us to do:
    There are two options:

    1. Define the fedora_modular_announce_list and fedora_modular_test_announce_list settings in Bodhi's production.ini file.
    2. Make Bodhi not log at error when these settings are undefined, which would be an upstream patch.
  • When do you need this? (YYYY/MM/DD)
    No due date, but we will get error e-mails until we do one or both of the above.

  • When is this no longer needed or useful? (YYYY/MM/DD)
    Only if fedora_modular is not longer a release in Bodhi.

  • If we cannot complete your request, what is the impact?
    We get annoying e-mails.

Background

Due to not having these settings defined, Bodhi is sending error e-mails, like this:

Message

[2018-04-17 03:07:19][bodhi.server ERROR]

Cannot find mailing list address for update notice

Process Details

  • host: bodhi-backend01.phx2.fedoraproject.org
  • PID: 150095
  • name: fedmsg-hub
  • command: /usr/bin/python2 /usr/bin/fedmsg-hub
  • msg_id:

Callstack that lead to the logging statement

  File "/usr/lib64/python2.7/threading.py", line 777 in __bootstrap
    self.__bootstrap_inner()
  File "/usr/lib64/python2.7/threading.py", line 804 in __bootstrap_inner
    self.run()
  File "/usr/lib/python2.7/site-packages/bodhi/server/consumers/masher.py", line 355 in run
    self.work()
  File "/usr/lib/python2.7/site-packages/bodhi/server/consumers/masher.py", line 438 in work
    self.send_stable_announcements()
  File "/usr/lib/python2.7/site-packages/bodhi/server/consumers/masher.py", line 69 in wrapper
    retval = method(self, *args, **kwargs)
  File "/usr/lib/python2.7/site-packages/bodhi/server/consumers/masher.py", line 744 in send_stable_announcements
    update.send_update_notice()
  File "/usr/lib/python2.7/site-packages/bodhi/server/models.py", line 2710 in send_update_notice
    log.error("Cannot find mailing list address for update notice")

Metadata Update from @bowlofeggs:
- Issue priority set to: Waiting on Asignee (was: Needs Review)

2 years ago

IMHO, we should send the test one to test@lists.fedoraproject.org (like we do for the test reports for rpms) and the announce ones should go to package-announce (like we do for rpms).

I guess I could be convinced to make a new module-announce list, but seems like overkill...

@adamwill or @sgallagh or @langdon might have thoughts...

I'm in favor of treating them the same as the equivalent traditional updates here.

Metadata Update from @bowlofeggs:
- Issue assigned to bowlofeggs

2 years ago

Added in ansible 3cdec8cdb130567cb83784522dd7673bfc939cc1

:foggy:

Metadata Update from @kevin:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

2 years ago

It turns out that Bodhi dies with this setting configured because someone thought it was a good idea to hard code what should be settings into Bodhi:

https://github.com/fedora-infra/bodhi/issues/2396

I think we should back out this change until we fix that issue.

(For the record, I backed out the change today.)(I don't know why that or this was in parenthesis.)

Login to comment on this ticket.

Metadata