#6800 Still no git notification for new package
Closed: Upstream 5 years ago by kevin. Opened 6 years ago by remi.

Already reported months ago... we still have no notification for newly added packages

Ex php-pragmarx-google2fa repository was created yesterday (~16:30 UTC)

This morning I import the package, so push some new commits (~6:30 UTC)

I didn't receive any notification, either by mail or on IRC (fedmsg-irc), only the new sources one (remi uploaded php-nikic-php-parser4-4.0.0-9c18e3d.tar.gz for rpms/php-nikic-php-parser4).

More the scm-commits is also broken for all new packages.

I think it is really time to fix all these REGRESSIONS in notification management, so we can work properly, as we were able ~1 year ago.


fmn is currently about 18 hours behind (not sure why), so you might get these notifications in a while.

fmn is currently about 18 hours behind (not sure why), so you might get these notifications in a while.

It looks like it got restarted on the 17th and several workers hit a bug in Celery 4.0.2 which caused them to crash on startup. I've started them all so FMN should clear out the ~32000 messages in the queue soon.

@remi, did you eventually get notifications?

@pingou, it looks like there was a rule for pkgdb: https://github.com/fedora-infra/fmn/blob/1d9d28fe6c5c1292c44da38560ca48f165523fc9/fmn/rules/pkgdb.py#L137. I assume this broke when the new package process on pagure was introduced. What's the equivalent message? org.fedoraproject.{stg,prod}.pagure.project.new?

Yeah, new packages emit pagure.project.new when emitted:

pagure.project.new -- limb created a new project "rpms/embree2" https://src.fedoraproject.org/rpms/embree2

This is not related to mail notification delayed.

Indeed I received notification about "uploaded new sources", but nothing about the commit.

Again, IRC notification (which are usually not delayed) are also affected.

Also affected
php-mock2
php-mock-integration2
* php-mock-phpunit2

Okay, the notification for new packages getting created should be fixed by the latest FMN which is now in production - the old pkgdb rule for new packages getting created has been replaced by a new Git rule "New repository in dist-git (https://src.fedoraproject.org)." and all old instances of the pkgdb rule have been migrated to the new rule.

However, there's still a number of pkgdb rules that no longer happen (because pkgdb got retired) with no replacement message from pagure.

So, this should be fixed. If you still see an issue with it, please re-open... as far as I can see the new packages are now notifying correctly.

Metadata Update from @kevin:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

6 years ago

Sorry, have to Re-open, as it still don't work.

Indeed it have been fixed for previous new packages
ex (tested this morning)

git.receive -- remi pushed to php-mock2 (master).  "test" https://src.fedoraproject.org/rpms/php-mock2/c/bed0d3d6ecfe53e3a61f991f62161a8bcddabc70?branch=master

but NOT for new package (ex php-sebastian-comparator3 created yesterday)

git.lookaside.new -- remi uploaded php-sebastian-comparator3-3.0.0-ed5fd22.tar.gz for rpms/php-sebastian-comparator3 https://src.fedoraproject.org/lookaside/pkgs/rpms/php-sebastian-comparator3/php-sebastian-comparator3-3.0.0-ed5fd22.tar.gz/sha512/693711148dc8950739c5db02b9dbf72bafe70e2d77e27ceaf7bf1392f7b2f675b02e6a37ee40c0e1170272285cefba91b17d943fbd598961405ff4f38d3f1b4b/php-sebastian-comparator3-3.0.0-ed5fd22.tar.gz
buildsys.tag -- remi's php-sebastian-comparator3-3.0.0-1.fc29 tagged into f29-pending by remi http://koji.fedoraproject.org/koji/taginfo?tagID=3430

Commit notifications still missing (both IRC and mail)

Metadata Update from @remi:
- Issue status updated to: Open (was: Closed)

5 years ago

ok, if you now push a test commit to php-sebastian-comparator3 does it work and emit a fedmg?

I think I see the current issue...

Metadata Update from @kevin:
- Issue assigned to kevin
- Issue priority set to: Waiting on Asignee

5 years ago

ok, if you now push a test commit to php-sebastian-comparator3 does it work and emit a fedmg?

 git.receive -- remi pushed to php-sebastian-comparator3 (master).  "test" https://src.fedoraproject.org/rpms/php-sebastian-comparator3/c/83ea1c1be98ba9f2439bb5b0a4369bb32c7e54b8?branch=master

So yes, notification received, fixed for "this" package.

The new release of pagure supports git templates.

@kevin, I've added the support but I don't quite know how it works, do you want to look into it?

'man git-init' has the info.

We could have ansible populate /usr/share/git-core/templates/ the way we want, or if pagure lets us override the default templatedir, we could make that (/usr/local/share/git-core/templates perhaps?)

Can we override the default? or should we put things there?

basically we just need to have ansible make the dir have the exact hooks and such we want and it will get copied in when git init runs on the new repo.

@pingou Where shall we place the hooks? Or is this now moot with newer releases?

@puiterwijk How does this work in the repospanner world? It just makes repos with the hooks defined? Or do we need to do something for new repos?

ok, talked to @puiterwijk and in repospanner this isn't a problem as the repo is setup with all hooks when it's created.

So, as soon as we roll repospanner into production this will be fixed.
That should be shortly after fedora-30 is released I hope.

Metadata Update from @kevin:
- Issue close_status updated to: Upstream
- Issue status updated to: Closed (was: Open)

5 years ago

Login to comment on this ticket.

Metadata