Until not long ago, the cgit instance on pkgs.fedoraproject.org was accessible via http://, and there are many BZ bugs with links to http://pkgs.fedoraproject.org/cgit/ which no longer work and lead to '403 Forbidden' error page. I noticed that https:// variants of those links do work, and now redirect to https://src.fedoraproject.org/cgit/ .
Can redirects be configured to ensure http://pkgs.fedoraproject.org/cgit/ links continue to work and redirect to https://src.fedoraproject/org/cgit/ just like their https:// equivalents? It should not matter much if they redirect http://pkgs -> https://src directly, or via redirect to https://pkgs.
This BZ search attempts to find bug created after Jan1 2017 with http:// links to pkgs.fp.o/cgit:
https://bugzilla.redhat.com/buglist.cgi?chfield=%5BBug%20creation%5D&chfieldfrom=2017-01-01&chfieldto=Now&classification=Fedora&longdesc=http%3A%2F%2Fpkgs.fedoraproject.org%2Fcgit%2F&longdesc_type=allwordssubstr&product=Fedora&query_format=advanced
It currently finds 294 bugs.
The same query only for https:// links finds nothing:
https://bugzilla.redhat.com/buglist.cgi?chfield=%5BBug%20creation%5D&chfieldfrom=2017-01-01&chfieldto=Now&classification=Fedora&longdesc=https%3A%2F%2Fpkgs.fedoraproject.org%2Fcgit%2F&longdesc_type=allwordssubstr&product=Fedora&query_format=advanced
ok. I think this should now be fixed.
Please test and let us know if there's still any /cgit/ ones that don't redirect properly?
Metadata Update from @kevin: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
I checked couple of links.
I found few links pointing to some patch in the master branch that was removed since the link was added. That problem is unrelated to this ticket and can not really be fixed.
Another problem I found is that few links have the format of: http://pkgs.fedoraproject.org/cgit/foo.git/ i.e. missing /rpms/ in between /cgit and foo.git. Those are broken regardless of whether http:// or https:// is used. So it's not directly related to this ticket, but noting it here as it should be possible to handle those via redirects. Not sure how tricky / risky that would be, whether there are only few path components that can appear after /cgit (rpms, tests, container, modules, any other?). This would also need to be updated for any new "namespace" is added in the future.
Well, I am not too in favor of complex rules. They start interacting oddly and then it becomes more and more difficult to modify them. So I would vastly prefer to just leave it at one simple rule for now...
I do understand that and I do not have strong need for having that fixed. Thank you!
Login to comment on this ticket.