We need to add two new settings to Bodhi's production.ini for WaiverDB:
production.ini
# The URL for waiverdb's API # waiverdb_api_url = https://waiverdb-web-waiverdb.app.os.fedoraproject.org/api/v1.0 # An access token used to authenticate to waiverdb # waiverdb.access_token =
We should add these before Bodhi 3.4.0 goes to production because it has a UI for waiving updates.
Here's an example staging update that you could try to waive: https://bodhi.stg.fedoraproject.org/updates/FEDORA-2018-8bfbe7247c
I'd forgotten that I already added these two settings to production.ini, so we don't need to add them, but we do still need to fill out the access token.
I've deployed a patch to Bodhi's staging instance that makes it so the waive button does not appear if waiverdb.access_token is not defined. This patch has been cherry picked to Bodhi's 3.4 branch, so we don't need to fix this ticket in order to deploy 3.4.0 next week. Thus, this ticket can be fixed whenever it is convenient for the admins.
waiverdb.access_token
3.4
Metadata Update from @ralph: - Issue tagged with: authentication
Metadata Update from @ralph: - Issue tagged with: waiverdb
To clarify - Bodhi does have a UI for waiving test results, but it is hidden until the auth token setting is defined. If we can get this in place after the freeze, I think it will make things easier for developers to waive tests.
Also I've never tested this UI (since I didn't have an auth token to test with) so I have no idea if it works.
This has been fixed last week at the hackathon no?
Yeah this is fixed now. Thanks @puiterwijk!
Metadata Update from @bowlofeggs: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Really? Cool. :) I was hoping to test it. Is it live in staging?
@ralph I had failed to notice that we didn't actually give staging Bodhi a token when I closed this, but I filed a new ticket about that: https://pagure.io/fedora-infrastructure/issue/6891
However, production has one (but is disabled due to https://github.com/fedora-infra/bodhi/issues/2272 which should get fixed in the upcoming 3.7.0 release).
Login to comment on this ticket.