https://whatcanidoforfedora.org used to work like websites, using the headers it detected user language.
The issue started october 2nd: https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org/thread/ID2JPUBV7TQZSQ6UQJDYDMBWXI4ML2J4/
Which was related to: https://pagure.io/fedora-infrastructure/issue/6378
Mayby @robyduck can help here to point to the code used for websites
@robyduck can you please provide a hint?
I am not aware how this works in Fedora apps. In websites we construct translations through some files, one of them is translations.ini, which generates a translations.html output file. We trigger the ULS selector and provide a list of languages in the config file (not all 500 languages ULS knows). However, if your language cannot be provided to you, we fall back to English.
Thanks for your answer. Publishing content works fine : https://whatcanidoforfedora.org/fr displays French content, which is ok.
What doesn't, when I go to https://whatcanidoforfedora.org it brings me to https://whatcanidoforfedora.org/en which is English content (obvious :p)
Can you explain how the user language detection is done in websites so @ralph can set it up the same way?
Can I work on this?
Checking into this issue this week. Adding it to my list of things to do for asknot.
@sadin any word here?
Metadata Update from @kevin: - Issue assigned to sadin - Issue priority set to: Waiting on Asignee
This seems to be fixed to me.
Please reopen if there's anything further to do here.
:whale2:
Metadata Update from @kevin: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Metadata Update from @jibecfed: - Issue status updated to: Open (was: Closed)
Issue: when opening https://whatcanidoforfedora.org the content displayed should correspond the language of the browser, following the same behavior as getfedora.org
On my browser, configured from fr-fr and fr before en, it does display english content.
Here my firefox language setting:
<img alt="Capture_decran_du_2018-12-28_23-42-16.png" src="/fedora-infrastructure/issue/raw/files/9d8e50774d9f5fec5cc6228d138ef95a21dc5aa4b35717b7428577afe1610cc8-Capture_decran_du_2018-12-28_23-42-16.png" />
Metadata Update from @cverna: - Assignee reset - Issue tagged with: help wanted
I made a fix for this at https://github.com/fedora-infra/asknot-ng/pull/122
I merged it and redeploy the service but I am not sure this is actually working, or I am not testing properly.
@mymindstorm and @jibecfed could you confirm that this is working now ?
it works fine, thanks a lot @mymindstorm !!!
@cverna : I'll communicate this great news to the translator mailing list <3 please expect to push a release next monday :)
Metadata Update from @jibecfed: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Can confirm that it's working on staging.
@jibecfed do you mind syncing the latest weblate translations to fix this issue before you deploy to prod?
it's the upstream project who merge translations from Weblate before publishing. all I can do is forcing the opening of the pull request: https://github.com/fedora-infra/asknot-ng/pull/123
The string causing an issue is: #das-webseiten-team. I can add this kind of checks to prevent future breakage: https://docs.weblate.org/en/latest/user/checks.html#regular-expression Do you know which regex to write to prevent this without creating more side effects?
Do you know which regex to write to prevent this without creating more side effects?
Weblate was already complaining with "Failed check: Trailing stop". I only fixed that string as it looked like the only one that was tied to a CSS selector.
Login to comment on this ticket.