#6457 Invalid signatures on wiki edit fedmsgs
Closed: Upstream 2 years ago Opened 2 years ago by bowlofeggs.

I've noticed a few e-mails from bodhi-backend02 (prod) about invalid signatures on fedmsgs pertaining to wiki edits. Here's the body of one of those e-mails:

Message

[2017-10-22 11:55:40][fedmsg.crypto.x509_ng ERROR]

message [{u'username': u'apache', u'i': 1, u'timestamp': 1508673340, u'msg_id': u'2017-f584679f-9aa2-4ac2-98fd-ce3682e7d46a', u'crypto': u'x509', u'topic': u'org.fedoraproject.prod.wiki.article.edit', u'msg': {u'watch_this': None, u'base_rev_id': False, u'title': u'R\xe9unions hebdomadaires de la French team', u'minor_edit': 4, u'section_anchor': None, u'url': u'https://fedoraproject.org/w/index.php?title=R%C3%A9unions_hebdomadaires_de_la_French_team&diff=prev&oldid=503938', u'user': u'Renault', u'revision': {u'mTextId': 482005, u'mUnpatrolled': None}}}] has an invalid signature: 

Process Details

  • host: bodhi-backend02.phx2.fedoraproject.org
  • PID: 37934
  • name: fedmsg-hub
  • command: /usr/bin/python /usr/bin/fedmsg-hub
  • msg_id:

Callstack that lead to the logging statement

  File "/usr/bin/fedmsg-hub", line 9 in <module>
    load_entry_point('fedmsg==0.19.1', 'console_scripts', 'fedmsg-hub')()
  File "/usr/lib/python2.7/site-packages/fedmsg/commands/hub.py", line 123 in hub
    command.execute()
  File "/usr/lib/python2.7/site-packages/fedmsg/commands/__init__.py", line 106 in execute
    return self.run()
  File "/usr/lib/python2.7/site-packages/fedmsg/commands/hub.py", line 101 in run
    framework=False,
  File "/usr/lib/python2.7/site-packages/moksha/hub/__init__.py", line 109 in main
    reactor.run(installSignalHandlers=False)
  File "/usr/lib64/python2.7/site-packages/twisted/internet/base.py", line 1194 in run
    self.mainLoop()
  File "/usr/lib64/python2.7/site-packages/twisted/internet/base.py", line 1206 in mainLoop
    self.doIteration(t)
  File "/usr/lib64/python2.7/site-packages/twisted/internet/epollreactor.py", line 396 in doPoll
    log.callWithLogger(selectable, _drdw, selectable, fd, event)
  File "/usr/lib64/python2.7/site-packages/twisted/python/log.py", line 101 in callWithLogger
    return callWithContext({"system": lp}, func, *args, **kw)
  File "/usr/lib64/python2.7/site-packages/twisted/python/log.py", line 84 in callWithContext
    return context.call({ILogContext: newCtx}, func, *args, **kw)
  File "/usr/lib64/python2.7/site-packages/twisted/python/context.py", line 118 in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "/usr/lib64/python2.7/site-packages/twisted/python/context.py", line 81 in callWithContext
    return func(*args,**kw)
  File "/usr/lib64/python2.7/site-packages/twisted/internet/posixbase.py", line 597 in _doReadOrWrite
    why = selectable.doRead()
  File "/usr/lib/python2.7/site-packages/txzmq/connection.py", line 284 in doRead
    log.callWithLogger(self, self.messageReceived, message)
  File "/usr/lib64/python2.7/site-packages/twisted/python/log.py", line 101 in callWithLogger
    return callWithContext({"system": lp}, func, *args, **kw)
  File "/usr/lib64/python2.7/site-packages/twisted/python/log.py", line 84 in callWithContext
    return context.call({ILogContext: newCtx}, func, *args, **kw)
  File "/usr/lib64/python2.7/site-packages/twisted/python/context.py", line 118 in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "/usr/lib64/python2.7/site-packages/twisted/python/context.py", line 81 in callWithContext
    return func(*args,**kw)
  File "/usr/lib/python2.7/site-packages/txzmq/pubsub.py", line 72 in messageReceived
    self.gotMessage(message[1], message[0])
  File "/usr/lib/python2.7/site-packages/moksha/hub/zeromq/zeromq.py", line 197 in chain_over_moksha_callbacks
    f(_body, _topic)
  File "/usr/lib/python2.7/site-packages/moksha/hub/zeromq/zeromq.py", line 224 in intercept
    return callback(ZMQMessage(_topic, _body))
  File "/usr/lib/python2.7/site-packages/moksha/hub/api/consumer.py", line 167 in _consume_json
    return self._consume(message_as_dict)
  File "/usr/lib/python2.7/site-packages/fedmsg/consumers/__init__.py", line 265 in _consume
    self.validate(message)
  File "/usr/lib/python2.7/site-packages/fedmsg/consumers/__init__.py", line 259 in validate
    if not fedmsg.crypto.validate(message['body'], **self.hub.config):
  File "/usr/lib/python2.7/site-packages/fedmsg/crypto/__init__.py", line 244 in validate
    return backend.validate(message, **cfg)
  File "/usr/lib/python2.7/site-packages/fedmsg/crypto/x509_ng.py", line 207 in validate
    m=message, e=str(e)))

I want to say we hit this long ago too and there was some reason for the failure that we couldn't fix.

@codeblock or @puiterwijk might recall?

Ah yep. Thats it indeed....

I am going to close this in favor of the upstream report...

:closed_book:

Metadata Update from @kevin:
- Issue close_status updated to: Upstream
- Issue status updated to: Closed (was: Open)

2 years ago

Login to comment on this ticket.

Metadata