#6279 new package processs is closing tickets due to "reviewer not a packager" but its wrong
Closed: Fixed 6 years ago Opened 6 years ago by pbrobinson.

See ticket:
https://pagure.io/releng/fedora-scm-requests/issue/70

Closed: invalid:
- Issue close_status updated to: Invalid
- Issue status updated to: Closed (was: Open)

how do you figure they're not a packager, they have 190 odd pacakges:

https://admin.fedoraproject.org/accounts/user/view/mtasaka
https://src.fedoraproject.org/user/mtasaka


Metadata Update from @pingou:
- Issue tagged with: src.fp.o

6 years ago

FTR, this is being worked on via emails. I expect there will be an update of this ticket some time soon

Perhaps they need to login to sync groups?

@pbrobinson @mtasaka the current code in fedrepo-req-admin's master branch (ticket processing tool) is more explicit on the error, so this will be improved in the future, but the current issue is that @mtasaka's email address in Bugzilla is "mtasaka@fedoraproject.org" but his FAS email address is "mtasaka@tbz.t-com.ne.jp". Since the email addresses are different, fedrepo-req-admin can't look up the user in FAS and determine if they are a packager.

There are two options.
You can add the mapping at:
https://github.com/fedora-infra/python-fedora/blob/develop/fedora/client/fas2.py#L145

You can also just modify the email address in Bugzilla to match yours in FAS. @limb can use --force when processing the ticket to override this issue in the short-term.

"foo @fedoraproject.org" address is always <FAS_NAME>@fedoraproject.org , so I guess looking up the FAS table should be easy, shouldn't it?

And I guess bugzilla is actually doing this mapping, because actually I can change fedora-review frag or can see fedora-contrib-only frag-ed bugzilla with "mtasaka @fedoraproject.org" address, and also "mtasaka @tbz.t-com.ne.jp" address (yes, I have BOTH on bugzilla), e.g.

https://bugzilla.redhat.com/show_bug.cgi?id=1439162

Usually I don't want to use " @tbz.t-com.ne.jp" address but want to use "@fedoraproject.org" address because it shows more explicitly that "I am fedora-FAS-ed user" and it is easy to remember.

@mtasaka, that's a good point. I'll modify that in fedrepo-req-admin.

@mtasaka your first point should be fixed with this PR:
https://pagure.io/fedrepo_req/pull-request/85

The other point is in a separate ticket.

@mprahl but the first bit of any @fp.o address is there FAS login so if the email address is a @fp.o address the FAS username can be determined and then looked up whether they're a packager from there.

@pbrobinson https://pagure.io/fedrepo_req/pull-request/85 addressed this.

It's now updated in f26.

So then, I think this is done/fixed?

Please re-open if there's still any issue to fix here.

:loudspeaker:

Metadata Update from @kevin:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

6 years ago

Login to comment on this ticket.

Metadata