[brain@ignatenko-w541 rpm]$ git push origin c2b0fdb:f23 -f -v Pushing to ssh://ignatenkobrain@pkgs.fedoraproject.org/forks/ignatenkobrain/rpms/rpm Total 0 (delta 0), reused 0 (delta 0) remote: FATAL: + refs/heads/f23 forks/ignatenkobrain/rpms/rpm ignatenkobrain DENIED by refs/heads/f[0-9][0-9] remote: error: hook declined to update refs/heads/f23 To ssh://pkgs.fedoraproject.org/forks/ignatenkobrain/rpms/rpm ! [remote rejected] c2b0fdb -> f23 (hook declined) error: failed to push some refs to 'ssh://ignatenkobrain@pkgs.fedoraproject.org/forks/ignatenkobrain/rpms/rpm'
I think this is completely fine to allow force-push for forks in any branches. Also, since it's possible to remove branches, it is just awkward that you can remove + create branch, but not force-push...
Metadata Update from @pingou: - Issue tagged with: src.fp.o
This is odd, you should be able to force-push to a fork
To ssh://pkgs.fedoraproject.org/forks/pingou/rpms/fedocal + 7a8b8be...bcd1419 master -> master (forced update)
Could you try again? (note I didn't change anything was just trying to replicate)
Metadata Update from @pingou: - Issue assigned to pingou
@pingou, try f26 branch ;)
ohh, now it works.
[brain@ignatenko-w541 rpm]$ git push origin 31f6752:master -f Total 0 (delta 0), reused 0 (delta 0) To ssh://pkgs.fedoraproject.org/forks/ignatenkobrain/rpms/rpm + 4341d10...31f6752 31f6752 -> master (forced update) [brain@ignatenko-w541 rpm]$ git push origin 31f6752:f26 -f Total 0 (delta 0), reused 0 (delta 0) To ssh://pkgs.fedoraproject.org/forks/ignatenkobrain/rpms/rpm + c0d73c0...31f6752 31f6752 -> f26 (forced update) [brain@ignatenko-w541 rpm]$ git push origin 31f6752:f23 -f Total 0 (delta 0), reused 0 (delta 0) remote: FATAL: + refs/heads/f23 forks/ignatenkobrain/rpms/rpm ignatenkobrain DENIED by refs/heads/f[0-9][0-9] remote: error: hook declined to update refs/heads/f23 To ssh://pkgs.fedoraproject.org/forks/ignatenkobrain/rpms/rpm ! [remote rejected] 31f6752 -> f23 (hook declined) error: failed to push some refs to 'ssh://ignatenkobrain@pkgs.fedoraproject.org/forks/ignatenkobrain/rpms/rpm'
so it doesn't work for any branches <= f23, for >= f24 works fine...
hm odd, I'll look into it
Out of curiosity, I wonder if fixing #6220 didn't also fix this one, could you check?
@pingou, nope =(
[brain@ignatenko-w541 rpm]$ git push origin eadbbd1:f23 -f eTotal 0 (delta 0), reused 0 (delta 0) remote: FATAL: + refs/heads/f23 forks/ignatenkobrain/rpms/rpm ignatenkobrain DENIED by refs/heads/f[0-9][0-9] remote: error: hook declined to update refs/heads/f23 To ssh://pkgs.fedoraproject.org/forks/ignatenkobrain/rpms/rpm ! [remote rejected] eadbbd1 -> f23 (hook declined) error: failed to push some refs to 'ssh://ignatenkobrain@pkgs.fedoraproject.org/forks/ignatenkobrain/rpms/rpm'
I think this is due to us using the same gitolite template for forks that we do for real packages...
repo forks/ignatenkobrain/rpms/rpm R = @all RW+C f24 = ignatenkobrain RW+C f25 = ignatenkobrain RW+C f26 = ignatenkobrain RW+C master = ignatenkobrain - f[0-9][0-9] = @all - epel[0-9] = @all - epel[0-9][0-9] = @all - el[0-9] = @all - olpc[0-9] = @all RW+C = ignatenkobrain
We should drop all the f, epel,el, olpc ones for forks.
Good catch, let's adjust pagure-dist-git for this then
Fixed in https://pagure.io/pagure-dist-git/pull-request/22
I think this is now fixed though some forks may still have the issue, we'll need to fix them as they show up
Metadata Update from @pingou: - Issue close_status updated to: Fixed
Login to comment on this ticket.