fedora-infrastructure

#6089 Update notification mails from module dist-git
Closed: Fixed Opened by lslebodn.

Closed: Fixed
Reopen Issue

I recently got am mail notification after other guy push patches to module dist-git for sssd. However, there wis a wrong link to repository and therefore we can see "Bad commit reference: 8ec94463a54210e88d72d93c952688b49bd6930a" after visiting the link.

Subject: phracek pushed to sssd (f26).  "First set of basic tests (..more)"                                                                                                                
MIME-Version: 1.0                                                                                                                                                                          
Content-Type: text/plain; charset="utf-8"                                                                                                                                                  
Content-Transfer-Encoding: base64                                                                                                                                                          
Message-Id: <20170530065540.83C796079262@bastion01.phx2.fedoraproject.org>                                                                                                                 
Date: Tue, 30 May 2017 06:55:40 +0000 (UTC)                                                                                                                                                
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 30 May 2017 06:55:40 +0000 (UTC)                                             
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 30 May 2017 06:55:40 +0000 (UTC) for IP:'10.5.126.12' DOMAIN:'bastion01.phx2.fedoraproject.org'       
        HELO:'bastion.fedoraproject.org' FROM:'notifications@fedoraproject.org' RCPT:''                                                                                                    
X-RedHat-Spam-Score: -0.301  (ALL_TRUSTED,BAYES_50,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RP_MATCHES_RCVD) 10.5.126.12 bastion01.phx2.fedoraproject.org 10.5.126.12                          
        bastion01.phx2.fedoraproject.org <notifications@fedoraproject.org>                                                                                                                 
X-Scanned-By: MIMEDefang 2.78 on 10.5.110.25                                                                                                                                               
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12                                                                                                                                                
phracek pushed to sssd (f26).  "First set of basic tests (..more)"                                                                                                                         
        https://src.fedoraproject.org/cgit/sssd.git/commit/?h=f26&id=8ec94463a54210e88d72d93c952688b49bd6930a

The link should point to module repository and not to the rpms: 

https://src.fedoraproject.org/cgit/rpms/sssd.git/commit/?h=f26&id=8ec94463a54210e88d72d93c952688b49bd6930a

vs.

https://src.fedoraproject.org/cgit/modules/sssd.git/commit/?h=f26&id=8ec94463a54210e88d72d93c952688b49bd6930a

Yeah, this has been reported before and in fact it's fixed upstream, we just need to push a new release with the fix out. ;(

https://github.com/fedora-infra/fmn/issues/176

Metadata Update from @kevin:
- Issue close_status updated to: Upstream
- Issue status updated to: Closed (was: Open)

It was fixed 2 months ago. Is there any ETA when it will be deployed to production?

@kevin Is there any change that it will be finally deployed. It was fixed in upstream 5onths ago
Edited by lslebodn

Metadata Update from @lslebodn:
- Issue status updated to: Open (was: Closed)

The actual problem is that fedmsg_meta doesn't know about namespaces. I believe the link is being created in this function.

I've filed an issue: https://github.com/fedora-infra/fedmsg_meta_fedora_infrastructure/issues/434

I was just reading the scm-commits list today and though I was knowing this issue exists since module commits started, I got confused again as there was many commits to modules in dist-git and just did not understand if its for package or for module.

Good to see this getting fixed soon.

So, we still need to land the fmn change in https://github.com/fedora-infra/fmn/issues/176 ?
Or did that already land?

and then we need the fix to fedmsg_meta_fedora_infrastructure?

Just trying to sort out what all is needed here so we can make sure and get it all landed...

https://github.com/fedora-infra/fmn/issues/176 is in production at the moment, so fedmsg_meta_fedora_infrastructure needs a fix, a release, and we need to update it on the FMN hosts.

I am pretty sure this is done now.

At least I see:

Sep 05 07:46:15 git.receive -- asamalik pushed to sssd (master). "add generated modulemd" https://src.fedoraproject.org/modules/sssd/c/e16164b3a4cb687be60cf324a158587e19fa6d21?branch=master

which has the correct modules path.

I am going to close this now, but feel free to reopen if there's further action to take here.

Metadata Update from @kevin:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.