#5645 Denied unretire requests still count as pending requests
Closed: Fixed Opened by smani.

It appears that denied unretire requests still count as pending and hence prevent new requests from being filed due to
"Could not save the request for branch: , has it already been requested?"

Concrete example: https://admin.fedoraproject.org/pkgdb/package/requests/9237


Just to note: I can't change the status of the request to Obsolete (in the hope that it would allow a proper request to be filed) because I didn't make the request. And smani can't change the status to Obsolete because he's not a pkgdb administrator.

I figured that I'd just change it back to the initial state and then just process it but before doing that I'd rather give folks a chance to see what pkgdb is actually doing here.

Basically, unique constraint does not take the status into account: https://github.com/fedora-infra/pkgdb2/blob/master/pkgdb2/lib/model/init.py#L1847-L1850

So yes this would be expected and the current solution would be to edit that request and put it back to Awaiting Review.
I see that this is likely not the best design and something we'll need to sort out.

thanks for the report :)

There is an ticket upstream for this issue: https://github.com/fedora-infra/pkgdb2/issues/283 so if everyone agrees, I would propose to close the present ticket.

Ok for me

Closing.

:fishing_pole_and_fish:

@kevin changed the status to Closed

Metadata