fedora-infrastructure

#5641 fedmenu on pkgs using rpms instead of package name
Closed: Fixed Opened by mcsontos.

Closed: Fixed
Reopen Issue

When visiting pkgs (or src), for example https://src.fedoraproject.org/cgit/rpms/ikiwiki.git,
there is the fedmenu linking other package related services. The following snippet is used to populate the menu:

<script>
    var base = 'https://apps.fedoraproject.org/';
    var tokens = window.location.href.split('/');
  var repo = null;
  if (tokens.length > 4 && tokens[4] != '') {
    repo = tokens[4].split('.')[0];
  }
  fedmenu({
      'url': base + 'js/data.js',
      'mimeType': 'application/javascript',
      'position': 'bottom-right',
      'package': repo,
  });
</script>

However, on this site this uses rpms instead of ikiwiki as package name.

Should this be more namespace aware? For rpms this should set the package, what about docker? (I somehow managed to get to https://src.fedoraproject.org/cgit/docker)

I failed to find more appropriate place where to report this.

Looks like changing 4 to 5 in the cgit-header.html could do the trick. Something like:

if (tokens.length > 5) {
  if (tokens[4] == 'rpms' && tokens[5] != '') {
    repo = tokens[5].split('.')[0];
  }
}

Would you like to make a patch for this we could apply?

0001-Fix-package-injected-to-fedmenu-on-pkgs.fp.o.patch

/me wonders if reply by mail with attachment does not work, or it is just so slow...

Reply by email should work, but attachments are likely not supported.

Thanks for the patch! :)

Applied as https://infrastructure.fedoraproject.org/cgit/ansible.git/commit/?id=de3af0e

And deployed https://src.fedoraproject.org/cgit/rpms/guake.git

Note: not all page are up to date yet as cgit has a cache of the pages served.

Thanks again :)

@pingou changed the status to Closed
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.