#5343 Commit emails to cluster-commits@lists.fedorahosted.org being rejected
Closed: Fixed None Opened 5 years ago by andyp.

The last two times I've pushed changes to the gfs2-utils.git repository the commit email has been rejected with this message:

Your message to the cluster-commits mailing-list was rejected for the following reasons:

The message comes from a moderated member

The original message as received by Mailman is attached.

I don't know why this has happened or whether it affects other committers but please can it be fixed asap? We use the mailing list to stay notified when other developers push commits so emails being rejected is pretty inconvenient.


Can you attach the message you got here? Or at least the headers so we could see what user it appears to be coming from?

One of the rejection emails, which has the original commit email attached
rejected-by-cluster-commits.eml

Is this related to the new Basset spam detector thing?

Replying to [comment:3 andyp]:

Is this related to the new Basset spam detector thing?

Nope, the Basset milter is not yet in production. :)

Anyhow, I am not sure how this worked before. It looks like the emails are coming from yourname@fedoraproject.org but most of the subscribers of the list are @redhat.com. I don't see any header rules or the like that would have accepted these either. ;(

So, I think we can:

1) subscribe everyones @fedoraproject.org address (and set them to nomail I guess).
or
2) add a rule on some header thats in the commit emails allowing it through.

Do you have a preference?

Replying to [comment:4 kevin]:

2) add a rule on some header thats in the commit emails allowing it through.

This seems like the more elegant solution to me. I wouldn't like to have a situation where committers (well, pushers) are required to subscribe to the list to have their commits show up on it.

There are more projects than gfs2-utils using this list though, so they would need to be catered for too.

{{{
$ grep 'X-Git-Module:' cluster-commits | dos2unix | sort -u
X-Git-Module: cluster.git
X-Git-Module: dlm.git
X-Git-Module: fence-agents.git
X-Git-Module: fence.git
X-Git-Module: gfs2-utils.git
}}}

ok. I added a header rule for this.

Can you try a commit and confirm it's working?

It doesn't seem to be working: I pushed a commit and received another rejection notification from the list as before.

ok. Try again? Sorry for this back and forth...

Sorry for the delay. I've tried again and it's still not working.

Hey, I'm investigating this too. Could you try again Andy please? It won't work better but I'll have more logs to look at. Thanks!

Replying to [comment:10 abompard]:

Could you try again Andy please? It won't work better but I'll have more logs to look at. Thanks!

Done. Thanks for looking at this.

OK, I found the reason. A quick and easy fix would be to allow list members to post to the list, would that be OK according to your policy? If not, we can also add rules that would reject any email not containing an allowed X-Git-Module header.

Replying to [comment:12 abompard]:

OK, I found the reason. A quick and easy fix would be to allow list members to post to the list

I assume you mean //non//-list members here. That would be ok but I would be concerned about spam, so:

If not, we can also add rules that would reject any email not containing an allowed X-Git-Module header.

is probably a better idea.

Nope, currently the list setup is to reject email from list members, and discard from non-members.

Should I set the list to accept email from members?

Replying to [comment:14 abompard]:

Nope, currently the list setup is to reject email from list members, and discard from non-members.

Huh, well that's confusing, how is it accepting any mail at all currently?

Replying to [comment:15 abompard]:

Should I set the list to accept email from members?

Well that sounds like a good idea if it would fix the problem. It should still accept email generated by git pushes whether the pusher is subscribed or not though.

Replying to [comment:16 andyp]:

Huh, well that's confusing, how is it accepting any mail at all currently?

There's a regexp to accept any email coming from @fedoraproject. But if that person is subscribed, the rule to reject emails from members takes precedence.

Well that sounds like a good idea if it would fix the problem. It should still accept email generated by git pushes whether the pusher is subscribed or not though.

Yeah, that's what the header matches are for. I've done the setup, can you test that it's working please?

That seems to have worked - thanks!

Login to comment on this ticket.

Metadata