I cleaned up the dist-git-upload.cgi a little bit to make it PEP8 compliant and remove some pyflakes warnings.
Thanks for the patch.
Overall it looks good, there's one mistake I can see: in your new line 156, you're adding one level of indentation. That line should stay at the indentation level it currently is.
In a few places, you're leaving the print >> sys.stderr ... construct. Any reason you didn't replace them by a sys.stderr.write(...) line as you did for the rest?
print >> sys.stderr ...
sys.stderr.write(...)
Other than that, it looks good to me.
attachment 0001-Make-dist-git-upload.cgi-PEP8-compliant.2.patch
attachment 0001-Make-dist-git-upload.cgi-PEP8-compliant.patch
Thank you for the review. Here is an updated patch. It is there twice now because I forgot to theck the box to overwrite the old patch. I just missed the other places because I started changing them to be able to easier wrap the lines after I wrapped some other lines already.
Should I go ahead and apply this (first in stg) and then prod? Would you all be available to fix/test at some point?
Sorry, I never reviewed the new patch.
It looks good to me, for whatever that's worth. :)
@kevin: Sure, if there's a need for help with problems caused by this, just ping me on IRC.
I pushed this into staging.
Can you try it out there and confirm all is well, and then I will push to prod.
This got pushed to prod and I have seen no complaints. ;)
Thanks.
Login to comment on this ticket.