#4952 Require a meeting topic when using zodbot meeting plugin -- #startmeeting <topic>
Closed: Fixed None Opened 4 years ago by decause.

= problem =
zodbot is amazing. It tracks thousands of IRC meetings each year, and is a crucial part of our communications infrastructure. Meeting logs can be found and searched later at https://meetbot.fedoraproject.org/, but without a meeting topic, the logs are much harder to locate.

= analysis =
We should probably require a meeting topic to #startmeeting?

= enhancement recommendation =
Before zodbot will actually #startmeeting, it will require the user to add a $MEETING_TOPIC. If they do not, zodbot will print out message in IRC to the effect of, "Please include a meeting topic so we can find your logs later."


I'd like to take a crack at this I've skimmed the code I have an idea on how to implement this.

Of note: The documentation has the plug in at '/usr/lib/python2.6/site-packages/supybot/plugins/MeetBot/...' but in actuality it is in:
[odin2016@value01 MeetBot]$ pwd
/usr/lib/python2.7/site-packages/supybot/plugins/MeetBot

It appears that python was upgraded and the documentation was not. That should also be done as part of this, specifically the command to process logs found in 'https://infrastructure.fedoraproject.org/infra/docs/zodbot.rst'

I've added a few lines to the #startmeeting requirements that will should not allow you to startmeeting without a topic. I was able to get access to a git repo for a version of meetbot where glhomes and another did the same thing to another instance of meetbot.

I will need to make a patch in the morning that we can test. I tried to test on a local install of supybot and it does not want to load the module properly, which is likely me trying to quickly spin it up and load in the plugin.

Adding nirik and puiterwijk to the CC for awareness since they have assisted me with setting up what I need to get this started and I may need a little more of that. Addtionally, I would need that assistance getting the patch applied as I have no manner of commit ability.

Replying to [comment:2 odin2016]:

I've added a few lines to the #startmeeting requirements that will should not allow you to startmeeting without a topic. I was able to get access to a git repo for a version of meetbot where glhomes and another did the same thing to another instance of meetbot.

I will need to make a patch in the morning that we can test. I tried to test on a local install of supybot and it does not want to load the module properly, which is likely me trying to quickly spin it up and load in the plugin.

Adding nirik and puiterwijk to the CC for awareness since they have assisted me with setting up what I need to get this started and I may need a little more of that. Addtionally, I would need that assistance getting the patch applied as I have no manner of commit ability.

Many thanks odin2016! I will keep an eye on this ticket for updates :)

--RemyD.

Patch to require a meeting topic to #startmeeting
meetbot-require-meeting-topic.patch

Patch to require a meeting topic with #startmeeting and fail if there is not one with a message why has been attached. If someone with the rights to take it the rest of the way could have a look and finish the process I would appreciate that. If they could possibly even update out buddy Zodbot and reload him, that would be excellent as well

More robust verison. Mkes sure that meeting name can be used by save. This is the patch I will put a bugzilla request in to have added to the package. Nirik has said he will add it when I put the bug in.
meetbot-require-meeting-topic.2.patch

More robust patch added. Makes sure that save can use the name in save, since we will be forcing the issue. I will attach the bugzilla request to have the patch added here when I put it in.

Bugzilla 1283357 created for package update.

This is now in place. ;)

Thanks!

This is excellent!

Super Thank You Everyone,

--RemyD.

As a note, I did make a change to the docs for this that updated the location to process logs form /usr/lib/python2.6 to /usr/lib/python2.7, as the phython2.6 path no longer exists on value01.

Login to comment on this ticket.

Metadata