#4811 cgit/.../patch/file shows patch not just for that file
Closed: Fixed None Opened 6 years ago by adelton.

= bug description =

When diff is shown for commit additional-attributes of https://fedorapeople.org/cgit/adelton/public_git/CGI-sessions.git for one source file (app.cgi) via

https://fedorapeople.org/cgit/adelton/public_git/CGI-sessions.git/diff/app.cgi?id=additional-attributes

it just shows patch for that one file.

When however you try to get the patch via

https://fedorapeople.org/cgit/adelton/public_git/CGI-sessions.git/patch/app.cgi?id=additional-attributes

to get the raw diff to pipe it to patch, it includes patch for lookup_identity.conf as well.

= bug analysis =

It seems patch does not show (semantically) the same output as diff. This used to work.

We had similar (albeit not the same) issue with the same URL at https://fedorahosted.org/fedora-infrastructure/ticket/4263

= fix recommendation =

Is something wrong with cgit?


I can confirm that I see the same thing here, but not sure yet whats causing it.

Will try and investigate later this week after we migrate fedorapeople.org later today.

This still seems to be the case, and I think it's an issue in cgit.

Would you be willing to report it to upstream? Or prefer I do so?

Replying to [comment:2 kevin]:

Would you be willing to report it to upstream? Or prefer I do so?

I'd prefer if you could do it -- you have access to those machines and configuration so you will be better positioned to answer questions that upstream undoubtedly will have about the exact cgit setup used.

I've mailed them, lets see what they say. ;)

ok, upstream created a patch which I did a build with, and it's fixed now. ;)

Should pick it up in the next regular release (but it's still patched on fedorapeople for now).

Sorry this took so long to get sorted out.

Login to comment on this ticket.

Metadata